https://bugzilla.redhat.com/show_bug.cgi?id=2297995 --- Comment #4 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> --- (In reply to Peter Lemenkov from comment #3) > * [Not a blocker] The file with licensing terms need some love. I don't > think that "Copyright (c) <year> <copyright holders>" is a valid licensing > term. However I see this as upstream issue not ours. In the mean time ask > upstream to fill placeholders with a real values. https://gitlab.gnome.org/World/Rust/libpanel-rs/-/issues/7 for getting upstream to fixup the license. > * The more worrying issue is that the resulting RPM package couldn't be > installed properly in chroot (while running fedora-review) on my machine. > Maybe there is something wrong with my system or the package intended for > fedora-41? Could you please investigate it? Confirmed that something is going on. I'll get it fixed. > * Looks like you accidentally packaged two copies of licensing. Since the > package heavily uses macros maybe adding it manually isn't necessary > anymore. Take a look at this one. The same story with README.md. This is common and known for the rust2rpm generated packages. I've not had to do anything about it for the other packages. > * Version 0.5.0 is out. Does anything stop you from packaging it? The latest version requires the entire gtk stack to be upgraded. This will be done in Rawhide at a later time. I think we want to try to sort out GIR syncing stuff before the upgrade of all of the packages. This will be handled at the Rust SIG level so I'm focused on packaging the compatible versions. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2297995 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202297995%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
