https://bugzilla.redhat.com/show_bug.cgi?id=2299900 --- Comment #3 from Arthur Bols <arthur@xxxxxxxx> --- (In reply to Peter Lemenkov from comment #2) > Looks Good to Me. Hoewver I see you have "%bcond_without tests" line and > yet you're not using this condition anywhere. Either remove it or add %check > section. Thanks for noticing, I'll remove it. Context about why the tests are not used: the tests need a git submodule, but even then I'm not sure how they should be used. Half of the tests fail and it seems like they should be compared to an output file in the repo, which also seems outdated. I don't think it's worth the effort. > Also looks like this package bundles zxing library. We had it in > Fedora repos while ago but now it's retired. Anyway a proper "Provides: > bundled(zxing)" should be added. A fork is still in the repos as `zxing-cpp`, sadly the sources used by qzxing are vastly different. I'll add the provides, thanks! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2299900 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202299900%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
