https://bugzilla.redhat.com/show_bug.cgi?id=2295820 --- Comment #9 from Tom Rix <trix@xxxxxxxxxx> --- (In reply to Jeremy Newton from comment #4) > Other comments: > > BuildRequires: clang%{llvm_maj_ver} > BuildRequires: lld%{llvm_maj_ver} > > If you're trying to use an LLVM version as hipcc, this is not necessary, > since hipcc requires this already. > > If so, I suggest that we could add a metapackage in > rocm-compilersupport.spec called hipcc-tools-extra to require the correct > clang package to reduce packaging complexity in this package. I would rather > keep all the llvm version information in rocm-compilersupport.spec if > possible, since LLVM is a bit complicated to deal with in the rocm stack. > > And as well, assuming everything above makes sense, I would add: > BuildRequires: rocm-compilersupport-macros > > and replace all %{llvm_maj_ver} with %{rocmllvm_version} Yes. This is cleaner. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2295820 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202295820%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
