https://bugzilla.redhat.com/show_bug.cgi?id=2295820 Tim Flink <tflink@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |tflink@xxxxxxxxxx CC| |tflink@xxxxxxxxxx --- Comment #2 from Tim Flink <tflink@xxxxxxxxxx> --- Overall, it looks good to me but there are 2 bigger things I'm concerned about: 1. Do the files in tensilite/Tensile/CustomKernels/ count as pre-generated code or content? - Is it possible to delete the CustomKernels directory and still build for gfx941 and gfx942 albeit with a less optimized setup? If so, I'd lean more towards content 2. How do we handle the "bundled" tensile. It's never installed by hipblaslt and only used during the build process and I don't know off hand how to handle that. I don't think that it needs to be added to the provides but I also don't know if there is anything preventing this from happening. There are a few minor things like BuildRequires and Provides that needed to be changed to build in mock but I'll submit a patch for that once the major questions are figured out. Also, are there any plans (upstream or just in Fedora) to start building and offering kernels for something beyond gfx90a? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2295820 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202295820%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
