https://bugzilla.redhat.com/show_bug.cgi?id=2284641 --- Comment #5 from Davide Cavalca <davide@xxxxxxxxxxxx> --- (In reply to Fabio Valentini from comment #4) > Some comments: > > - Why add a patch to "unbreak" tests instead of just passing "-f testing" to > %cargo_test? Because I didn't know this was an option :) > - Is bumping from zstd 0.9 to 0.13 safe? It's a feature that is not compiled > by default. > There's no way to see if bumping the dep causes issues without enabling > the "compression" feature during the build. Upstream had previously bumped it to 0.11.2 in git, afaict it should be fine. > - "tsan_suppressions.txt" doesn't look like %docs. Please exclude it from > the package. Will do > - You're rm-ing some tests in %check without explanation. Please either > don't drop them or explain why they are dropped. There's a comment in the rust2rpm.toml, these fail to build in a way that breaks the build early on and prevents excluding them normally. I'll add a comment in the spec as well. > - It might also be a good idea to exclude the "art" folder from the -devel > package. It only contains unused images. Will do -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2284641 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202284641%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
