https://bugzilla.redhat.com/show_bug.cgi?id=2284641 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx Flags| |fedora-review? Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Some comments: - Why add a patch to "unbreak" tests instead of just passing "-f testing" to %cargo_test? - Is bumping from zstd 0.9 to 0.13 safe? It's a feature that is not compiled by default. There's no way to see if bumping the dep causes issues without enabling the "compression" feature during the build. - "tsan_suppressions.txt" doesn't look like %docs. Please exclude it from the package. - You're rm-ing some tests in %check without explanation. Please either don't drop them or explain why they are dropped. - It might also be a good idea to exclude the "art" folder from the -devel package. It only contains unused images. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2284641 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202284641%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
