https://bugzilla.redhat.com/show_bug.cgi?id=2296168 wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | --- Comment #5 from wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> --- (In reply to Fabio Valentini from comment #4) > Do you know where devise 0.4.1 was published from? > The git repo only shows history up to 0.4.0: > https://github.com/SergioBenitez/Devise/blob/master/lib/Cargo.toml I don't. It was released from 104e797d440d6fb7e8ba107cca27714a71cc368a that doesn't exist in GitHub. The mentioned commit changed the line at https://github.com/SergioBenitez/Devise/blob/master/core/src/from_meta/meta_item.rs#L147 from "let msg = match self.name() {" to "let msg = match self.name().map(|i| i.to_string()) {" It goes into devise_core though. I think, I'll just create a MR, so that it won't be missed for eventual 0.4.2. > It would also be great if upstream could release new versions that contain > the license files that you added. Last time it took a bit time and follow-up reminders until he accepted my MR with licenses. Going this route again may halt my going up the dependency chain for aw-server-rust for a bit longer. Is a new create with licenses important for you, before approving this package? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2296168 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202296168%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
