[Bug 2290696] Review Request: rust-bitfield-struct - Struct-like procedural macro for bit-fields

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2290696

Oliver Steffen <osteffen@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |rust-bitfield-struct -      |rust-bitfield-struct -
                   |Procedural macro for        |Struct-like procedural
                   |bitfields that allows       |macro for bit-fields
                   |specifying bitfields as     |
                   |structs.                    |



--- Comment #3 from Oliver Steffen <osteffen@xxxxxxxxxx> ---
(In reply to Fabio Valentini from comment #2)
> Two questions:
> 
> 1. The latest release is 0.8.0. You are packaging 0.6.2. Do you specifically
> need a version in the >=0.6,<0.7 range?
The dependent crate (still to be packaged) currently requires 0.7.0.
Updating the spec file to that version.

> 2. The "summary and description strings were shortened" comment is a bit
> confusing to me. Your Summary and descriptions are both *longer* than the
> one generated by rust2rpm:
> 
> +Struct-like procedural macro for bit-fields
> -Struct-like procedural macro for bitfields
True. The comment should be:
Changed Summary and Description, changing the spelling of 'bitfields' to
make the linter happy.

> And the bug title doesn't match the summary of the package.
That was the summary from crates.io which does not match the crate file.
Fixed.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2290696

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202290696%23c3

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux