https://bugzilla.redhat.com/show_bug.cgi?id=2293272 --- Comment #20 from Jakub Jelinek <jakub@xxxxxxxxxx> --- (In reply to Simone Caronni from comment #14) > Some notes in the SPEC file. > > This is not required for the review, but honestly please adjust all the > conditionals, it's a new package, let's start clean and not carrying over I'll work on cutting down the conditionals soon. > Last but not least, considering this is a compatibility package, instead of > pulling out from git snapshots you might want to use the latest release > tarballs from https://ftp.gnu.org/gnu/gcc/. This would simplify the SPEC > file substantially, also for new releases (when moving this to GCC 14 > comes). Isn't that feasible? I always used release tarballs for the same > purpose: https://github.com/negativo17/cuda-gcc/blob/master/cuda-gcc.spec The use of git snapshot is IMNSHO really important, there can be up to a year and something in between upstream tarballs (in 50% it is myself doing them upstream) and the amount of fixes in between is large and highly desirable. But more importantly, by using the same tarball (+ patches if any) as the system compiler in older Fedora releases at least for some time (as long as those are supported) one shares the testing done for the other compilers, bugs reported against one can be fixed in the others and vice versa. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2293272 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202293272%23c20 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
