https://bugzilla.redhat.com/show_bug.cgi?id=2293272 --- Comment #14 from Simone Caronni <negativo17@xxxxxxxxx> --- Some notes in the SPEC file. This is not required for the review, but honestly please adjust all the conditionals, it's a new package, let's start clean and not carrying over all the old stuff. We're targeting Fedora 40+ only and/or RHEL 10 on a limited set of architectures, so you can remove most of the conditionals that make the SPEC file unreadable. I know it's easier to get the GCC spec file and just adjust it for the different path/name, but we don't need to support RHEL 7 on a custom build for IA64 or Alpha!... I don't see why someone should build this on Fedora releases that have been EOL since years and on RHEL releases which already have SCL dev toolsets available: %if 0%{?fedora} >= 36 || 0%{?rhel} >= 10 %global build_annobin_plugin 1 %else %global build_annobin_plugin 0 %endif %if 0%{?fedora} >= 29 || 0%{?rhel} > 7 BuildRequires: binutils >= 2.31 %else BuildRequires: binutils >= 2.24 %endif %if 0%{?fedora} >= 29 || 0%{?rhel} > 7 Requires: binutils >= 2.31 %else Requires: binutils >= 2.24 %endif %if 0%{?fedora} >= 18 || 0%{?rhel} >= 7 %ifarch %{arm} Requires: glibc >= 2.16 %endif %endif %if 0%{?fedora} >= 29 || 0%{?rhel} > 7 %patch -P10 -p0 -b .rh1574936~ %endif %if 0%{?fedora} >= 21 || 0%{?rhel} >= 7 %if %{attr_ifunc} --enable-gnu-indirect-function \ %endif %endif %if 0%{?rhel} >= 9 --with-cpu-32=power9 --with-tune-32=power9 --with-cpu-64=power9 --with-tune-64=power9 \ %else --with-cpu-32=power8 --with-tune-32=power8 --with-cpu-64=power8 --with-tune-64=power8 \ %endif The same goes for conditionals for most architectures: %ifarch %{ix86} x86_64 ppc ppc64 ppc64le ppc64p7 s390 s390x %{arm} aarch64 %{mips} ia64 sparc sparcv9 alpha Any code path / conditionals (%ifarch/%ifnarch) which is not in these architectures you can probably throw away; I guess we don't want to keep old stuff lying around forever: %{ix86} x86_64 ppc64le s390x aarch64 Typo: "# For VTA guality testing" This Provides you can probably remove: Provides: compat-gcc(major) = %{gcc_major} The changelog does not match the release: Release: %{gcc_release}.1%{?dist} * Mon Jul 8 2024 Jakub Jelinek <jakub@xxxxxxxxxx> 13.3.1-2 Last but not least, considering this is a compatibility package, instead of pulling out from git snapshots you might want to use the latest release tarballs from https://ftp.gnu.org/gnu/gcc/. This would simplify the SPEC file substantially, also for new releases (when moving this to GCC 14 comes). Isn't that feasible? I always used release tarballs for the same purpose: https://github.com/negativo17/cuda-gcc/blob/master/cuda-gcc.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2293272 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202293272%23c14 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
