[Bug 2295731] Review Request: rust-git-interactive-rebase-tool - Full-featured terminal-based sequence editor for Git interactive rebase

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2295731



--- Comment #10 from Benjamin Gilbert <bgilbert@xxxxxxxxxxxx> ---
Thanks for the review!

> Please don't use macros prefixed by two underscores like %__install. They are RPM internals. Use plain "install" instead.

Fixed.

> It's a bit funny that this is included in the LICENSE file ...
> The project doesn't actually include the GPL-3.0 license text, as far as I can tell.
> Please ask upstream to actually include the full license text too.

Good catch!  PR in
https://github.com/MitMaro/git-interactive-rebase-tool/pull/933, and I've
updated the package to paste in a COPYING file for now.

Spec URL:
https://fedorapeople.org/~bgilbert/srpm/rust-git-interactive-rebase-tool.spec
SRPM URL:
https://fedorapeople.org/~bgilbert/srpm/rust-git-interactive-rebase-tool-2.4.1-1.fc40.src.rpm

rust2rpm.toml:
https://fedorapeople.org/~bgilbert/srpm/rust-git-interactive-rebase-tool-rust2rpm.toml


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2295731

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202295731%23c10

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux