https://bugzilla.redhat.com/show_bug.cgi?id=2295731 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx --- Comment #9 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Looks good to me, with two exceptions: > %{__install} -p src/interactive-rebase-tool.1 -t %{buildroot}%{_mandir}/man1 -D -m 644 Please don't use macros prefixed by two underscores like %__install. They are RPM internals. Use plain "install" instead. > You should have received a copy of the GNU General Public License > along with this program. If not, see <https://www.gnu.org/licenses/>. It's a bit funny that this is included in the LICENSE file ... The project doesn't actually include the GPL-3.0 license text, as far as I can tell. Please ask upstream to actually include the full license text too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2295731 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202295731%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
