> > > > The BuildRequires on elfutils-libelf-devel, zlib-devel and clang might be > > leftovers from building with vendored sources? > > > > Clang is needed for libbpf-rs to compile the bpf program embedded in bpftop. > libbpf-cargo handles the bpf compilation when you run `cargo build`, but it > relies on clang. If you're only using libbpf-cargo here, and libbpf-cargo relies on clang internally, then libbpf-cargo should pull in clang. > > The Packages for Rust crates > > should already pull in zlib-devel etc. (and clang for bindgen) as needed. > > My assumption is that it would be better to be explicit about the > dependencies needed and not to rely on transitive deps from the crates. I > assumed that it doesn't hurt. But happy to follow what you think is idea. In general, the rule of thumb is to only explicitly depend on things that you need *directly*. In this case, the package for libbpf-cargo should probably add a dependency on clang, if it's not working without it? > > Other than that, the package looks good to me! > > Thanks! I will wait to hear back and adjust accordingly. > > > > > PS: The spec file you added here: > > https://github.com/Netflix/bpftop/commit/a737971 is only compatible with > > recent versions of Fedora and RHEL 9 + EPEL, but will not work for building > > a package on any other RPM-based linux distribution. So I'm not sure how > > much benefit there is in keeping it in the upstream github repo. > > I can remove it. I wanted to put it there while I iterated on the spec. You don't need to remove it. I just wanted to let you know that keeping a separate copy of it might be of limited value long-term. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2281565 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202281565%23c12 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
