https://bugzilla.redhat.com/show_bug.cgi?id=2281565 --- Comment #12 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Jose Fernandez from comment #11) > > There are some BuildRequires and Requires that don't look like they are > > actually necessary: > > > > """ > > BuildRequires: elfutils-libelf-devel > > BuildRequires: zlib-devel > > BuildRequires: clang > > > > Requires: elfutils-libelf > > Requires: zlib > > """ > > > > Is there a specific reason why you added these? > > I'm under the impression that libelf and zlib are required at link time to > build bpftop because it pulls in libbpf-rs, which compiles libbpf. They are > also needed for bpftop to run since it loads a bpf program. From the libbpf > docs: > "libelf and zlib are internal dependencies of libbpf and thus are required > to link against and must be installed on the system for applications to > work." > https://docs.kernel.org/bpf/libbpf/libbpf_build.html If libbpf already pulls these in, then you don't need to depend on them. > > > > At least the Requires for elfutils-libelf and zlib are unnecessary. Both > > libraries are dynamically linked, and dependencies on them are generated by > > RPM automatically. > > How does RPM detect that they are dependencies?
