https://bugzilla.redhat.com/show_bug.cgi?id=2283540 --- Comment #5 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to Ben Beasley from comment #4) > (In reply to Sandro from comment #2) > > (In reply to Ben Beasley from comment #1) > > > Please add to python3-pyopengltk: > > > > > > Requires: libX11 > > > > Added. I suppose it's okay to *not* make this an explicit BR as well? > > > > Spec URL: https://gui1ty.fedorapeople.org/review/python-pyopengltk.spec > > SRPM URL: > > https://gui1ty.fedorapeople.org/review/python-pyopengltk-0.0.4-2.fc41.src.rpm > > Well, that’s a good point. I think you *should* add the BR too, both because > explicit is better in general, and because it may someday save you from > accidentally building a package that fails to install. > > However, you can do that on import. Thanks for the review and the advice. I'll add the BR on import. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2283540 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283540%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
