https://bugzilla.redhat.com/show_bug.cgi?id=2283540 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Sandro from comment #2) > (In reply to Ben Beasley from comment #1) > > Please add to python3-pyopengltk: > > > > Requires: libX11 > > Added. I suppose it's okay to *not* make this an explicit BR as well? > > Spec URL: https://gui1ty.fedorapeople.org/review/python-pyopengltk.spec > SRPM URL: > https://gui1ty.fedorapeople.org/review/python-pyopengltk-0.0.4-2.fc41.src.rpm Well, that’s a good point. I think you *should* add the BR too, both because explicit is better in general, and because it may someday save you from accidentally building a package that fails to install. However, you can do that on import. The package is APPROVED by inspection of the spec-file diff: --- srpm-unpacked/python-pyopengltk.spec 2024-05-26 20:00:00.000000000 -0400 +++ python-pyopengltk.spec 2024-07-03 10:20:01.353216195 -0400 @@ -1,13 +1,3 @@ -## START: Set by rpmautospec -## (rpmautospec version 0.6.3) -## RPMAUTOSPEC: autorelease, autochangelog -%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: - release_number = 1; - base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); - print(release_number + base_release_number - 1); -}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} -## END: Set by rpmautospec - %global pypi_name pyopengltk Name: python-%{pypi_name} @@ -37,6 +27,7 @@ %package -n python3-%{pypi_name} Summary: %{summary} Requires: python3-tkinter +Requires: libX11 %description -n python3-%{pypi_name} %_description @@ -71,7 +62,4 @@ %changelog -## START: Generated by rpmautospec -* Mon May 27 2024 Sandro <devel@xxxxxxxxxxxxx> - 0.0.4-1 -- Initial package -## END: Generated by rpmautospec +%autochangelog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2283540 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283540%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
