https://bugzilla.redhat.com/show_bug.cgi?id=2293766 --- Comment #12 from Akashdeep Dhar <akashdeep.dhar@xxxxxxxxx> --- Hello @jkadlcik@xxxxxxxxxx, > The package description should be wrapped to 80 characters per line > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description I will shorten the description. > Ideally, a summary != description. I will probably use the current longer description as the summary here but worst-case scenario, I will still prefer to have the same string in both places. > The licensecheck.txt mentions these two files with the MIT license. I'm not sure if the package license should then be "AGPL-3.0-or-later AND MIT" or not. I'm not sure here either as my license-fu is weak, but I think that the MIT license is permissive enough to be compatible with the AGPL-3.0-or-later license. > The changelog is meant for tracking the package changes, not upstream changes Fair. I will remove the larger units from the changelog section and include a link to the upstream GitHub release where folks can see the release if needed. Thanks for the review, @jkadlcik@xxxxxxxxxx! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2293766 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202293766%23c12 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
