https://bugzilla.redhat.com/show_bug.cgi?id=2293766 --- Comment #11 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Hello Akashdeep, overall the package looks good, there are just a few minor issues. > %global desc Guest operated service for creating bootable USB storage devices at any community conference kiosk The package description should be wrapped to 80 characters per line https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description > Summary: %{desc} Ideally, a summary != description. > > MIT License > ----------- > syncstar-0.1.0a3-build/syncstar-0.1.0a3/syncstar/frontend/static/css3/bs.min.css > syncstar-0.1.0a3-build/syncstar-0.1.0a3/syncstar/frontend/static/jscn/bs.min.js The licensecheck.txt mentions these two files with the MIT license. I'm not sure if the package license should then be "AGPL-3.0-or-later AND MIT" or not. > %changelog The changelog is meant for tracking the package changes, not upstream changes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2293766 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202293766%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
