https://bugzilla.redhat.com/show_bug.cgi?id=2278422 --- Comment #13 from wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> --- (In reply to Jerry James from comment #9) > (In reply to wojnilowicz from comment #8) > > The spec file is big, so there are some issues for sure, but I cannot find > > anymore, so it LGTM. The package is APPROVED. Thanks for explaining the > > raised issues. > > Thank you for sticking with me through this ordeal. Whew! No problem :) > > BTW, before writing the part under "# These two files are identical", you > > did know the %fdupes macro, right? It takes all the thinking from you. > > Yes, but in this case it wasn't clear to me which one should be the symlink > and which the real file, so I punted and hardlinked them. :-) Wouldn't a simple "%fdupes %{buildroot}%{python3_sitelib}/nbdime" create a hardlink in your case too? That's what I see in my nodejs-aw-webui case. %fdupes reference at https://src.fedoraproject.org/rpms/fdupes/blob/rawhide/f/macros.fdupes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2278422 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202278422%23c13 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
