https://bugzilla.redhat.com/show_bug.cgi?id=2263790 --- Comment #29 from Martin Hoyer <mhoyer@xxxxxxxxxx> --- Thanks Petr! Might I suggest starting with `pyp2spec yq --license Apache-2.0`, as there are some inconsistencies with the reference? For example: URL: https://pypi.org/project/yq/ VCS: git:%{srcforge} Source0: %{pypi_source yq} --- URL: https://github.com/kislyuk/yq Source: %{pypi_source yq} (also it's not srcforge) Other than that: > BuildRequires: sed I believe this is redundant > Requires(post): %{_bindir}/alternatives Not saying it's wrong, but `update-alternatives` is being used in the guidelines - https://docs.fedoraproject.org/en-US/packaging-guidelines/Alternatives/ > Patch1: yq-tomlkit-f39.patch Again, nothing wrong with that, but since there already is sed workaround for the setuptools_scm, also for F39, why not have two seds instead? > %{?python_provide:%python_provide python3-%{srcname}} I believe this is also redundant >sed -e 's/^version_file/#write_to/' -i pyproject.toml Just curious why is write_to commented out -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2263790 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202263790%23c29 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
