> it should be marked as `Conflicts`/`Obsoletes` since python3-slugify is effectively dead In that case, the package should probably use the %py_provides macro to generate the correct Provides. Note that this project doesn't look so alive either, the last upstream commit was three years ago. ========== >Please note that this is a non-binding review. Some notes on the issues from the future sponsor: >Summary: >- License needs clarification, ambiguity with between spec file and upstream. > See comment below. I agree with Cristian, this should be OK. The included license file matches the BSD-3-Clause license. >- It's not clear what is being packaged. The package depends on python3-slugify > but does not specify this as a dependency in the spec file. See the Provides and Requires > section of the python packaging guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides_and_requirements It looks like this is a replacement for the "slugify" Python package (and it doesn't depend on it). But if it *is* a replacement, it needs to be handled as such (see Conflicts / Obsoletes / Provides mentioned above). >- The upstream sources for the package seem to only contain a test suite that uses a > dependecy to carry out checks. If this is the case, then it is perhaps better > to simply include the tests with the upstream package for python3-slugify. It looks like __init__.py contains the actual code. It's a bit unusual, but not wrong. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2208353 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202208353%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
