https://bugzilla.redhat.com/show_bug.cgi?id=2281588 --- Comment #16 from Tomi Lähteenmäki <lihis@xxxxxxxxx> --- (In reply to david08741 from comment #15) > The rpm documentation [0] says ${RPM_....} should be preferred, i.e. > ${RPM_BUILD_ROOT} should be used instead of %{buildroot} > > [0] > https://rpm-software-management.github.io/rpm/manual/spec.html#build- > scriptlets Fedora Packaging Guidelines [0] says to pick a style and use it consistently throughout your packaging. I was about to switch to ${RPM_BUILD_ROOT} per the recent discussion in devel-list [1] but since I have used %{buildroot} in my other packages it would be consistent. [0] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_using_buildroot_and_optflags_vs_rpm_build_root_and_rpm_opt_flags [1] https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/thread/75YHNFYFT4EMA4PDKQRFRPFTVLWCFBCU/#L6GYEJFRLEPTPOAQDKJKFYLKWSBPGPYK -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2281588 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202281588%23c16 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
