https://bugzilla.redhat.com/show_bug.cgi?id=2283055 --- Comment #47 from Daniel Berrangé <berrange@xxxxxxxxxx> --- Not a must have requirement, but I usually suggest to minimize use wildcards at the top levels of generic directories. eg in the -devel package you have these two: %{_prefix}/include/* %{_libdir}/*.so You don't have a very big list of files to add without a wildcard, so the wildcard isn't a huge benefit. Manually listed the expected files ensures that if there is some unexpected change or build system mistake in a future version, that causes headers/libraries to go missing, you'll see it quickly. I've seen too many cases over the years where files silently go missing and aren't noticed by the package maintainer due to wildcard usage. These wildcards are fine to keep as-is though: %{_libdir}/lib%{name}.so.1{,.*} > - Set `CIO_LOCATOR_FILE` on the `make` command line. Copr build logs show this now being honoured in the compiler args, so that's good. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2283055 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283055%23c47 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
