https://bugzilla.redhat.com/show_bug.cgi?id=2281999 --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Ben Beasley from comment #4) > I’m leaning toward agreeing that these bundled assets should be treated as > content, and the approach here looks acceptable. It still wouldn’t hurt to > include an ancillary Source archive with the “original sources” if > practical, but in this case it looks like that would be fairly burdensome, > as everything is tied together with git submodules upstream. That pretty much matches my assessment. The bundled contents are a mix of XML + YAML (for syntax highlighting grammars) and XML + JSON (for themes). I think that makes it pretty clear that they qualify as "content" and not as "code" - they are purely "non-executable data". As for including the original sources, yes, that would be a massive PITA due to dozens of multi-level git submodules :( So I would like to avoid that, if possible. Do you think the way the bundled components are listed in the spec file is OK? I included version / snapshot information for the two major components (i.e. the git ref of "bat" that this crate is based on, plus the git ref of the Sublime Text grammars repo that was included in bat at that point in time). As for the other bundled grammars and themes, they are all git submodules / snapshots at random points in time, most repos without git tags, so I don't think I can assign a meaningful version to them. The licenses for all bundled grammars and themes are listed and included in the license tag, and patched into the cargo metadata so that our tooling (i.e. the %cargo_license{,_summary} macros) works correctly. The license of the first-party Sublime Text grammars is now also explicitly allowed by Fedora Legal, and classified as LicenseRef-Fedora-UltraPermissive (see https://gitlab.com/fedora/legal/fedora-license-data/-/issues/516 and the associated MR). I included this expression in the license tag of the package for completeness, but I don't think it needs to be "inherited" by applications that use this crate, so I didn't include it in the cargo metadata patch. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2281999 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202281999%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
