https://bugzilla.redhat.com/show_bug.cgi?id=2281999 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx --- Comment #4 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Fabio Valentini from comment #3) > Some background info that might help with the review: > > The bundled contents (Sublime Text grammars and themes) are only present in > a compressed binary format. They are generated from plain-text files > upstream, but those plain-text files are not included in the published > crates. However, the compressed binary format still includes license texts > and attributions for all bundled grammars and themes, which are accessible > programmatically (similar to the output of "bat --acknowledgements"). If we consider these to include any “code,” we would be bound to include the original source files in the source RPM even if we are not actually rebuilding the generated code in the RPM build. https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#pregenerated-code If these could all be considered “content,” then we don’t necessarily have such a requirement, unless covered by a specific guideline like https://docs.fedoraproject.org/en-US/packaging-guidelines/Web_Assets/#_css. A quick overview of https://github.com/sharkdp/bat/tree/master/assets suggests that themes are .tmTheme configuration files in an XML format, and syntaxes are .tmPreferences files in an XML format, .sublime-syntax files in a YAML format, and sometimes some cruft in JSON formats. I’m leaning toward agreeing that these bundled assets should be treated as content, and the approach here looks acceptable. It still wouldn’t hurt to include an ancillary Source archive with the “original sources” if practical, but in this case it looks like that would be fairly burdensome, as everything is tied together with git submodules upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2281999 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202281999%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
