https://bugzilla.redhat.com/show_bug.cgi?id=2270968 --- Comment #6 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Ankur Sinha (FranciscoD) from comment #5) > (Scrubbing my mock chroots fixed it. I should do that more often) > > Looks very good. Just a clarification before approving: Thanks for the review! > - I see this in the build log: > > ``` > [1/1] Cythonizing src/fcl/fcl.pyx > […] > ModuleNotFoundError: No module named 'fcl.fcl' > Failed to import fcl.fcl. It is probably not correctly compiled. > ``` > > Is this something to worry about? This appears in %generate_buildrequires and in %build before the compiler is invoked. So I think it is fair to consider it noise. The compiled module imports correctly where it matters, in %check, installing it to a mock chroot and running “python3 -c 'import fcl.fcl'” works fine to, and after all, we should not be able to import the compiled extension until we have compiled it. The import is attempted at all because of [tool.setuptools.dynamic] version = {attr = "fcl.__version__"} in pyproject.toml, and it succeeds – to the extent it imports the pure-Python portions of the package, which is enough to obtain the version number – just noisily. It would be nice if there were a clean way to silence the expected warning at this point in the build, but I can’t think of a tidy way, since even changing this to [tool.setuptools.dynamic] version = {attr = "fcl.version.__version__"} causes fcl/__init__.py to be imported and triggering the message along the way. > - I noticed this in the build log too, but that isn't anything in the > package: > > ``` > + /usr/bin/add-determinism --brp -j8 > /builddir/build/BUILDROOT/python-python-fcl-0.7.0.6-1.fc41.x86_64 > Cannot initialize handler pyc: ModuleNotFoundError: No module named > 'marshalparser' > […] Thanks for noticing that. I’ll bring that up with the people working on https://fedoraproject.org/wiki/Changes/ReproduciblePackageBuilds. I don’t think the ModuleNotFoundError is expected. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2270968 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202270968%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
