[Bug 2243131] Review Request: metadata-cleaner - Python GTK application to view and clean metadata in files, using mat2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2243131



--- Comment #29 from Artem <ego.cordatus@xxxxxxxxx> ---
>> Release:    0%{?dist}

> We start at 1 in Fedora (Suse 0), but modern package uses %autorelease

OK. 0%{?dist} only using before import to official Fedora repo.

non-%autorelease used for Copr compatibility but maybe this not relevant now.
OK.


>> Summary:    Python GTK application to view and clean metadata in files, using mat2

> It's over 80 characters

Without spaces it's exactly 80 characters. Fedora-review also didn't warn about
long summary. But OK, I'll shorten it.


> although I am not sure why you split it from the main package

Due warn:
metadata-cleaner.noarch: W: package-with-huge-docs 83%

  Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 19425 bytes in 2 files.

Since main package is non-arched there is less reasons for this. Especially
with this case where '%find_lang %{appid} --with-gnome' macros grabs help and
localization files altogether.

---

Spec URL:
https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-40-x86_64/07465429-metadata-cleaner/metadata-cleaner.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-40-x86_64/07465429-metadata-cleaner/metadata-cleaner-2.5.5-1.fc40.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2243131

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202243131%23c29
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux