https://bugzilla.redhat.com/show_bug.cgi?id=2243131 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx CC| |zebob.m@xxxxxxxxx --- Comment #28 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- > %global forgeurl https://gitlab.com/rmnvgr/%{name} Please %global forgeurl https://gitlab.com/rmnvgr/metadata-cleaner > Release: 0%{?dist} We start at 1 in Fedora (Suse 0), but modern package uses %autorelease > Summary: Python GTK application to view and clean metadata in files, using mat2 It's over 80 characters, just use Summary: View and clean metadata in files, using mat2 > Supplements: (%{name} = %{version}-%{release} and langpacks-<locale>) This is never used, just Requires: %{name}-langpacks = %{version}-%{release} from the main package, although I am not sure why you split it from the main package. Main package is noarch, it may have been interesting if it was arched, but even then the package is less than 2 MB. - Bump the package to 2.5.5 > Source0: %{forgesource} Remove the 0 for modern SPECs. > %changelog Use %autochangelog in conjonction wuth %autorelease My take: %global forgeurl https://gitlab.com/rmnvgr/%{name} %global tag v%{version} %global appid fr.romainvigier.MetadataCleaner %global gtk_version 4.6 Name: metadata-cleaner Version: 2.5.5 %forgemeta Release: %autorelease Summary: Python GTK application to view and clean metadata in files, using mat2 # - The source code is released under the terms of the GNU General Public # License 3.0 or later. # - The original artwork and translations are released under the terms of the # Creative Commons Attribution-ShareAlike 4.0 International. # - Additional icons from the Icon Development Kit of the GNOME Design Team are # released under the terms of the CC0 1.0 Universal. License: GPL-3.0-or-later AND CC-BY-SA-4.0 AND CC0-1.0 URL: %{forgeurl} Source: %{forgesource} BuildArch: noarch BuildRequires: desktop-file-utils BuildRequires: itstool BuildRequires: libappstream-glib BuildRequires: meson >= 0.59.0 BuildRequires: pkgconfig(gtk4) >= %{gtk_version} Requires: dbus-common Requires: gtk4 >= %{gtk_version} Requires: hicolor-icon-theme Requires: libadwaita >= 1.2 Requires: mat2 Requires: yelp %global _description %{expand: Metadata within a file can tell a lot about you. Cameras record data about when and where a picture was taken and which camera was used. Office applications automatically add author and company information to documents and spreadsheets. This is sensitive information and you may not want to disclose it. This tool allows you to view metadata in your files and to get rid of it, as much as possible. Under the hood, it relies on mat2 to parse and remove the metadata.} %description %_description %prep %forgeautosetup -p1 %build %meson %meson_build %install %meson_install %find_lang %{appid} --with-gnome %check appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/%{appid}.metainfo.xml desktop-file-validate %{buildroot}%{_datadir}/applications/%{appid}.desktop %files -f %{appid}.lang %license LICENSE.md LICENSES/* %doc README.md CHANGELOG.md %{_bindir}/%{name} %{_datadir}/%{name}/ %{_datadir}/applications/%{appid}.desktop %{_datadir}/dbus-1/services/*.service %{_datadir}/glib-2.0/schemas/*.gschema.xml %{_datadir}/icons/hicolor/scalable/*/%{appid}.svg %{_datadir}/icons/hicolor/symbolic/*/%{appid}-symbolic.svg %{_metainfodir}/%{appid}.metainfo.xml %changelog %autochangelog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2243131 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202243131%23c28 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
