https://bugzilla.redhat.com/show_bug.cgi?id=2094246 --- Comment #11 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Initial comments: a) Requires is typically not needed for libraries as the tooling will automatically determine any libraries that are linked during the build process and ensure they are required if they are included in BuildRequires b) For the desktop file add BuildRequires: desktop-file-utils to the spec file and in the check section add: desktop-file-validate %{buildroot}/%{_datadir}/applications/gnunet-uri.desktop see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage c) Group entry in spec file is typically not added d) All licenses should be listed, not just the main license for the package. Based on https://download.copr.fedorainfracloud.org/results/schanzen/gnunet/fedora-rawhide-x86_64/07164125-gnunet/fedora-review/licensecheck.txt would expect some of the following to be relevant for some of the sub packages: *No copyright* Public domain ---------------------------- gnunet-0.21.1/src/service/cadet/desirability_table.c BSD 2-Clause License and/or BSD 2-clause NetBSD License ------------------------------------------------------- gnunet-0.21.1/src/cli/gns/gnunet-gns-proxy-setup-ca.in gnunet-0.21.1/src/service/transport/gnunet-transport-certificate-creation.in BSD 3-Clause License -------------------- gnunet-0.21.1/src/lib/pq/versioning.sql gnunet-0.21.1/src/service/transport/ieee80211_radiotap.h Creative Commons CC0 1.0 and/or GNU Affero General Public License v3.0 or later ------------------------------------------------------------------------------- gnunet-0.21.1/src/lib/util/crypto_elligator.c See https://docs.fedoraproject.org/en-US/legal/license-field/ e) should the section: %preun %systemd_preun %{name}.service %postun %systemd_postun_with_restart %{name}.service %systemd_user_post %{name}-user.service be changed to %preun %systemd_preun %{name}.service %systemd_user_preun %{name}-user.service %postun %systemd_postun_with_restart %{name}.service %systemd_user_postun %{name}-user.service see: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2094246 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202094246%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
