https://bugzilla.redhat.com/show_bug.cgi?id=2277753 --- Comment #3 from Paul Howarth <paul@xxxxxxxxxxxx> --- Hi Petr, thanks for the review. (In reply to Petr Pisar from comment #2) > TODO: Move the indefinite article to the same line as "distribution" word is > in the description. OK, will do. > TODO: Build-require 'perl(:VERSION) >= 5.6' (Makefile.PL:5). OK, but how much value does it bring? Fedora Core 1 had perl 5.8 after all. > TODO: Remove the '>= 0.88' constraint from 'perl(Test::More)' dependency. I > think it's not needed. It's there because t/basic.t uses "done_testing". > FIX: Do not build-require 'perl(ExtUtils::HasCompiler)', 'perl(IPC::Cmd)', > and 'perl(Perl::OSType)'. They are not used at tests. True, but I prefer to keep them because they will be runtime dependencies anyway, and having them as build requirements helps to avoid nasty surprises when, for example, the perl packages are rebuilt for EPEL-10 and a freshly-built version of this package could be uninstallable if say perl-ExtUtils-HasCompiler) isn't already built. > Otherwise, the package is in line with Fedora and Perl packaging guidelines. > Please correct the FIX item and consider fixing the TODO items before > building this package. > Resolution: Package APPROVED. Thanks again for the review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2277753 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277753%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
