https://bugzilla.redhat.com/show_bug.cgi?id=2277753 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA512: d4aba77f52f47c7399164762285e5c42e5eb4ffc5e7c13cf993e8c45975e9e96ac5d6db25817ab88dfa7ba0acdd69109b47dcf193c7cffe890044cfc660a951a) is original. Ok. Summary verified from lib/CPAN/Requirements/Dynamic.pm. Ok. Description verified from lib/CPAN/Requirements/Dynamic.pm. Ok. TODO: Move the indefinite article to the same line as "distribution" word is in the description. License verified in README, LICENSE, dist.ini, and lib/CPAN/Requirements/Dynamic.pm. Ok. No XS code, noarch BuildArch is Ok. TODO: Build-require 'perl(:VERSION) >= 5.6' (Makefile.PL:5). TODO: Remove the '>= 0.88' constraint from 'perl(Test::More)' dependency. I think it's not needed. FIX: Do not build-require 'perl(ExtUtils::HasCompiler)', 'perl(IPC::Cmd)', and 'perl(Perl::OSType)'. They are not used at tests. All tests pass. Ok. $ rpmlint perl-CPAN-Requirements-Dynamic.spec ../SRPMS/perl-CPAN-Requirements-Dynamic-0.001-2.fc41.src.rpm ../RPMS/noarch/perl-CPAN-Requirements-Dynamic-0.001-2.fc41.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 === 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 0.3 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-CPAN-Requirements-Dynamic-0.001-2.fc41.noarch.rpm drwxr-xr-x 2 root root 0 Apr 29 02:00 /usr/share/doc/perl-CPAN-Requirements-Dynamic -rw-r--r-- 1 root root 151 Apr 27 17:17 /usr/share/doc/perl-CPAN-Requirements-Dynamic/Changes -rw-r--r-- 1 root root 385 Apr 27 17:17 /usr/share/doc/perl-CPAN-Requirements-Dynamic/README drwxr-xr-x 2 root root 0 Apr 29 02:00 /usr/share/licenses/perl-CPAN-Requirements-Dynamic -rw-r--r-- 1 root root 19744 Apr 27 17:17 /usr/share/licenses/perl-CPAN-Requirements-Dynamic/LICENSE -rw-r--r-- 1 root root 2878 Apr 29 02:00 /usr/share/man/man3/CPAN::Requirements::Dynamic.3pm.gz drwxr-xr-x 2 root root 0 Apr 29 02:00 /usr/share/perl5/vendor_perl/CPAN drwxr-xr-x 2 root root 0 Apr 29 02:00 /usr/share/perl5/vendor_perl/CPAN/Requirements -rw-r--r-- 1 root root 9674 Apr 27 17:17 /usr/share/perl5/vendor_perl/CPAN/Requirements/Dynamic.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-CPAN-Requirements-Dynamic-0.001-2.fc41.noarch.rpm | sort -f | uniq -c 1 perl(Carp) 1 perl(CPAN::Meta::Prereqs) 1 perl(CPAN::Meta::Requirements::Range) 1 perl(ExtUtils::Config) 1 perl(ExtUtils::HasCompiler) 1 perl(IPC::Cmd) 1 perl(Module::Metadata) 1 perl(Parse::CPAN::Meta) 1 perl(Perl::OSType) 1 perl(strict) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-CPAN-Requirements-Dynamic-0.001-2.fc41.noarch.rpm | sort -f | uniq -c 1 perl(CPAN::Requirements::Dynamic) = 0.001 1 perl-CPAN-Requirements-Dynamic = 0.001-2.fc41 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-CPAN-Requirements-Dynamic-0.001-2.fc41.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=117747094). Ok. Otherwise, the package is in line with Fedora and Perl packaging guidelines. Please correct the FIX item and consider fixing the TODO items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2277753 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277753%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
