https://bugzilla.redhat.com/show_bug.cgi?id=2277858 --- Comment #5 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thank you for the review! (In reply to Fabio Valentini from comment #4) > Having taken a look, I think I can confirm your analysis that the "andes" > conda package looks fine to distribute, and its contents are not included in > the built RPMs. I'm not sure why the project has decided to use such a weird > thing as test data, but oh well. > > I'm slightly concerned about the amount of effort that's required to run the > test suite of this package though. > Most of the dev-dependencies are quite large (axum, tower, tokio, rstest) or > outdated and can't be easily patched (async_zip 0.0.15). > It's great that you went through the process of making it work, I'm just > worried whether it's going to be sustainable long-term. The async_zip 0.0.15 dependency is a frustrating one. Unfortunately, that’s also a build dependency, not just a test dependency, so we can’t get rid of it by simply disabling the tests. (As previously mentioned, uv currently carries its own forked async_zip that will have to be bundled as a git snapshot, but we still can’t really package async_http_range_reader without its build dependencies. At that point we might as well bundle it in uv too.) For the large dev dependencies, I figured they are likely to be kept packaged and working for other applications, and can probably be kept working here since they’re used in a pretty straightforward way, API-wise. I do think it’s worth trying to keep running the tests on a “best reasonable effort” basis. However, if it gets to the point where this is untenable, or it looks like we would have to start maintaining compat packages just for this package’s tests, I’m perfectly willing to disable them again. > > Also note that a new version of this crate was released since you filed this > review - v0.8.0. > But It's fine to import the current version if that's what you need. Aha, so there is. It looks like the change in https://github.com/prefix-dev/async_http_range_reader/compare/v0.7.1...v0.8.0 is straightforward, and the current release of uv has already updated its dependencies, so I’ll update to 0.8.0 right away, with no packaging changes required other than the version number. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2277858 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277858%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
