https://bugzilla.redhat.com/show_bug.cgi?id=2277858 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review+ Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Having taken a look, I think I can confirm your analysis that the "andes" conda package looks fine to distribute, and its contents are not included in the built RPMs. I'm not sure why the project has decided to use such a weird thing as test data, but oh well. I'm slightly concerned about the amount of effort that's required to run the test suite of this package though. Most of the dev-dependencies are quite large (axum, tower, tokio, rstest) or outdated and can't be easily patched (async_zip 0.0.15). It's great that you went through the process of making it work, I'm just worried whether it's going to be sustainable long-term. Also note that a new version of this crate was released since you filed this review - v0.8.0. But It's fine to import the current version if that's what you need. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass ! latest version of the crate is packaged (v0.7.1 vs. v0.8.0) - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2277858 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277858%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
