https://bugzilla.redhat.com/show_bug.cgi?id=2279244 --- Comment #3 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> --- Thanks for the feedback with this still in such a raw state. Cleanup of the spec will happen after all outstanding issues are solved. I was able to use the system CLI11 and unbundle that. The Fedora magic_enum package installs into /usr/include so a simple symlink wont work. Eigen3 is more stubborn. We should be able to use the system eigen3, and it's required to be installed for checks to pass for the main source code, but getting the bundled basalt-headers to do the right thing has resulted in the likely need to patch thirdparty/basalt-headers/CMakeLists.txt. I wasn't able to find a configuration that would use the system libs and still pass their custom cmake function logic. Details in the updated spec. Tests fixed and are running now, thanks for point out those additional git submodules. Hopefully we've found them all now. %files updated based on feedback. Spec URL: https://jsteffan.fedorapeople.org/imrsv/basalt.spec SRPM URL: https://jsteffan.fedorapeople.org/imrsv/basalt-0-1.20240310git673cc5c.fc39/basalt-0-1.20240310git673cc5c.fc39.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2279244 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279244%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
