https://bugzilla.redhat.com/show_bug.cgi?id=2279244 Davide Cavalca <davide@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |davide@xxxxxxxxxxxx --- Comment #2 from Davide Cavalca <davide@xxxxxxxxxxxx> --- Some notes from a quick skim: > tar -xvf %{SOURCE1} --strip-components 1 -C thirdparty/CLI11 > tar -xvf %{SOURCE4} --strip-components 1 -C thirdparty/magic_enum These two are header-only libraries and they're already packaged, you might be able to add them as BRs and symlink them in place to unbundle them > tar -xvf %{SOURCE8} --strip-components 1 -C thirdparty/basalt-headers/thirdparty/eigen You also have eigen3 in the BRs. Is this really using _both_ the system eigen3 and the bundled eigen? > # CMake errors: > # -DBUILD_TESTS=on \ > #thirdparty/basalt-headers/test/googletest does not contain a CMakeLists.txt file > #thirdparty/basalt-headers/test/benchmark does not contain a CMakeLists.txt file This is because basalt-headers pulls these two in via submodules: https://gitlab.freedesktop.org/mateosss/basalt-headers/-/tree/main/test > %{_libdir}/libbasalt.so.* You want to glob the soversion here so we don't accidentally bump it without noticing > %{_datarootdir}/basalt/* You should own the whole directory, not just its contents -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2279244 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279244%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
