[Bug 2279515] Review Request: rust-sqlformat - Formats whitespace in a SQL string to make it easier to read

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2279515



--- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
As mentioned in
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279513#c2, now that we
have rust2rpm 26, you can stop doing the modification below manually:

--- rust-sqlformat.spec 2024-05-11 08:39:33.669918456 -0400
+++ ../srpm-unpacked/rust-sqlformat.spec        2024-04-25 20:00:00.000000000
-0400
@@ -14,6 +14,10 @@
 Source:         %{crates_source}

 BuildRequires:  cargo-rpm-macros >= 24
+# Do downstream crate metadata changes programmatically in %%prep. Since
%%prep
+# runs before %%generate_buildrequires, we must add the following manually
+# rather than generating a dynamic BuildRequires via rust2rpm.toml.
+BuildRequires:  tomcli

 %global _description %{expand:
 Formats whitespace in a SQL string to make it easier to read.}

Instead, you can add

  [requires]
  build = [
      "tomcli",
  ]

and tomcli will now be a regular static BuildRequires (so it will be installed
in time to use it in %prep).

This isn’t something you’re required to change, but it will make your life
easier when updating the package in the future.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2279515

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279515%23c2
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux