[Bug 2278420] Review Request: python-jupytext - Save Jupyter notebooks as text documents or scripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2278420



--- Comment #11 from wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> ---
I just wanted to approve the package because to me it looks great, but found 
two checks that prevented me from doing so.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======


===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License". 1877 files have unknown license. Detailed output of
     licensecheck in /var/lib/copr-rpmbuild/results/python-
     jupytext/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
     Note: License file installed only when python-jupytext-doc is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/licenses, /usr/share/man, /usr,
     /usr/lib/python3.12, /usr/share/man/man1, /usr/share,
     /usr/lib/python3.12/site-packages, /usr/share/jupyter, /usr/lib,
     /usr/share/jupyter/labextensions, /usr/share/doc,
     /etc/jupyter/jupyter_notebook_config.d,
     /etc/jupyter/jupyter_server_config.d, /usr/bin, /etc, /etc/jupyter
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/doc,
     /usr/share/licenses, /usr/share/man, /usr/lib/python3.12/site-
     packages, /usr, /usr/lib/python3.12,
     /etc/jupyter/jupyter_notebook_config.d, /usr/share,
     /etc/jupyter/jupyter_server_config.d, /usr/share/man/man1,
     /usr/share/jupyter, /usr/lib, /usr/share/jupyter/labextensions, /etc,
     /etc/jupyter, /usr/bin
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 7961 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Binary eggs must be removed in %prep
     Note: Cannot find any build in BUILD directory (--prebuilt option?)
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files

===== SHOULD items =====

Generic:
[!]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-jupytext , python3-jupyterlab-jupytext
     Note: "Requires: jupyterlab" is not versioned and at
    
https://github.com/mwouts/jupytext/blob/main/jupyterlab/packages/jupyterlab-jupytext-extension/README.md#installation
     it says that for jupyterlab < 4.0 you need an older version of this
extension.
     Could you add versioned dependency so that "rpm -q --requires
python3-jupyterlab-jupytext" 
     will return jupyterlab >= 4.0 (eventually >=4.0 and < 5.0) instead of just
jupyterlab?
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.


Rpmlint
-------
Checking: python3-jupytext-1.16.2-1.fc41.noarch.rpm
          python3-jupyterlab-jupytext-1.16.2-1.fc41.noarch.rpm
          python-jupytext-doc-1.16.2-1.fc41.noarch.rpm
          python-jupytext-1.16.2-1.fc41.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpgsd_s48n')]
checks: 32, packages: 4

python3-jupytext.noarch: W: python-leftover-require python-jupyter-filesystem
python3-jupytext.noarch: W: no-manual-page-for-binary jupytext-config
python3-jupyterlab-jupytext.noarch: W: no-documentation
python-jupytext.spec: W: invalid-url Source1: jupytext-1.16.2-vendor.tar.xz
python3-jupytext.noarch: W: devel-file-in-non-devel-package
/usr/bin/jupytext-config
 4 packages and 0 specfiles checked; 0 errors, 5 warnings, 21 filtered, 0
badness; has taken 1.4 s 




Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "python3-jupytext".
(none): E: there is no installed rpm "python3-jupyterlab-jupytext".
(none): E: there is no installed rpm "python-jupytext-doc".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts
============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0
badness; has taken 0.0 s 



Source checksums
----------------
https://github.com/mwouts/jupytext/archive/v1.16.2/jupytext-1.16.2.tar.gz :
  CHECKSUM(SHA256) this package     :
68a09dc8393bd5ceff995cf60377d53e003f0035ddf2f6bc2e23fa46e3575380
  CHECKSUM(SHA256) upstream package :
68a09dc8393bd5ceff995cf60377d53e003f0035ddf2f6bc2e23fa46e3575380


Requires
--------
python3-jupytext (rpmlib, GLIBC filtered):
    /usr/bin/python3
    config(python3-jupytext)
    python(abi)
    python-jupyter-filesystem
    python3.12dist(markdown-it-py)
    python3.12dist(mdit-py-plugins)
    python3.12dist(nbformat)
    python3.12dist(packaging)
    python3.12dist(pyyaml)

python3-jupyterlab-jupytext (rpmlib, GLIBC filtered):
    jupyterlab
    python(abi)
    python3-jupytext

python-jupytext-doc (rpmlib, GLIBC filtered):



Provides
--------
python3-jupytext:
    config(python3-jupytext)
    python-jupytext
    python3-jupytext
    python3.12-jupytext
    python3.12dist(jupytext)
    python3dist(jupytext)

python3-jupyterlab-jupytext:
    bundled(npm(base64-js))
    bundled(npm(buffer))
    bundled(npm(ieee754))
    bundled(npm(jupyterlab-rise))
    python-jupyterlab-jupytext
    python3-jupyterlab-jupytext
    python3.12-jupyterlab-jupytext

python-jupytext-doc:
    python-jupytext-doc



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name
python-jupytext --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, Python
Disabled plugins: SugarActivity, Haskell, Java, PHP, R, Ocaml, C/C++, fonts,
Perl
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2278420

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202278420%23c11
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux