[Bug 2279333] Review Request: elementary-greeter - LightDM Login Screen for the elementary desktop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2279333

Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |code@xxxxxxxxxxxxxxxxxx



--- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
Is there a specific reason for using the “traditional” snapshot versioning
style

https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots_2

Version:        7.0.0
Release:        2.%{commitdate}.git%{shortcommit}%{?dist}

rather than the current style?


https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots

Version:        7.0.0^%{commitdate}git%{shortcommit}
Release:        2%{?dist}

I also notice that, while the guidelines for the old snapshot information field
in the release only have “suggested” formats,

- YYYYMMDD.<revision>
- YYYYMMDD<scm><revision>

the ones for the new snapshot information field in the version say one of the
following formats “should” be followed:

- <date>.<revision>
- <date><scm><revision>
- <number>.<revision>
- <number>.<scm><revision>

%{commitdate}.git%{shortcommit}%{?dist} is <date>.<scm><revision>, which
doesn’t exactly match any of these formats.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2279333

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279333%23c3
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux