https://bugzilla.redhat.com/show_bug.cgi?id=2279272 --- Comment #8 from Felix Wang <topazus@xxxxxxxxxxx> --- Thanks for the review by you both. > This should be dropped and "BuildArch: noarch" should be used instead. Done. > This should use the modern snapshot versioning rather than the legacy version-in-release variant. The version is wrong too, since the pkgconfig file says it's "1.0". > Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots There is no tag version release on the upstream, so I use "Version: 0^%{date}git%{shortcommit}" > When upstream has never chosen a version, you must use Version: 0. > This should be simplified to "%{_datadir}/wlr-protocols/" (note the trailing slash) Done. Spec URL: https://topazus.fedorapeople.org/wlr-protocols.spec SRPM URL: https://topazus.fedorapeople.org/wlr-protocols-0%5e20240126git2b8d433-1.fc39.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2279272 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279272%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
