https://bugzilla.redhat.com/show_bug.cgi?id=2279272 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@xxxxxxxxx --- Comment #7 from Neal Gompa <ngompa13@xxxxxxxxx> --- There are errors in this package that need to be fixed: Spec review: > # no debug information > %global debug_package %{nil} This should be dropped and "BuildArch: noarch" should be used instead. > Version: 0.0.0 > Release: %autorelease This should use the modern snapshot versioning rather than the legacy version-in-release variant. The version is wrong too, since the pkgconfig file says it's "1.0". Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots > %dir %{_datadir}/wlr-protocols > %dir %{_datadir}/wlr-protocols/unstable > %{_datadir}/wlr-protocols/unstable/*.xml This should be simplified to "%{_datadir}/wlr-protocols/" (note the trailing slash) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2279272 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279272%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
