[Bug 2276290] Review Request: rust-jemalloc-sys - Rust FFI bindings to jemalloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2276290



--- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
(In reply to wojnilowicz from comment #2)
> I try to package this aw-server-rust and it has this as a dependency for
> Linux and x86 as seen at
> https://github.com/ActivityWatch/aw-server-rust/blob/
> c056e50646b45070c330de8a6dbd14042b3455e4/aw-server/Cargo.toml#L40

Yes, but custom allocators are, by definition, optional.
We already have a handful of packages in Fedora that drop custom allocators
because they are painful to deal with.

> Couldn't we just remove the noarch line and limit valid architectures with
> ExclusiveArch similarly to
> https://pkgs.rpmfusion.org/cgit/nonfree/nvidia-340xx-kmod.git/tree/nvidia-
> 340xx-kmod.spec#n34
> ?

No, that would be wrong.

The correct solution would be to use the "supported-arches" setting in
rust2rpm.toml to specify that the crate should only be built and tested on
certain architectures.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2276290

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202276290%23c3
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux