[Bug 2009155] Review Request: python-oslo-messaging - OpenStack common messaging library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2009155



--- Comment #16 from Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> ---
Hello Jakub, Thanks for your kind review and the advice! I fixed the license
name and the checksum error for now.

Spec URL: https://hiwkby.fedorapeople.org/python-oslo-messaging.spec
SRPM URL:
https://hiwkby.fedorapeople.org/python-oslo-messaging-14.7.0-2.fc41.src.rpm

Here is the diff. 
```
$ diff -c python-oslo-messaging.spec.3 python-oslo-messaging.spec 
*** python-oslo-messaging.spec.3        Fri Apr 19 02:54:30 2024
--- python-oslo-messaging.spec  Wed May  1 17:16:59 2024
***************
*** 15,26 ****
  %global pypi_name oslo.messaging
  %global pkg_name oslo-messaging

! Name:       python-oslo-messaging
  Version:    14.7.0
! Release:    1%{?dist}
  Summary:    OpenStack common messaging library

! License:    ASL 2.0
  URL:        https://opendev.org/openstack/oslo.messaging
  Source0:   
https://tarballs.openstack.org/%{pypi_name}/%{pypi_name}-%{upstream_version}.tar.gz
  # Required for tarball sources verification
--- 15,26 ----
  %global pypi_name oslo.messaging
  %global pkg_name oslo-messaging

! Name:       python-%{pkg_name}
  Version:    14.7.0
! Release:    2%{?dist}
  Summary:    OpenStack common messaging library

! License:    Apache-2.0
  URL:        https://opendev.org/openstack/oslo.messaging
  Source0:   
https://tarballs.openstack.org/%{pypi_name}/%{pypi_name}-%{upstream_version}.tar.gz
  # Required for tarball sources verification
***************
*** 191,196 ****
--- 191,199 ----


  %changelog
+ * Tue Apr 30 2024 Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> - 14.7.0-2
+ - Fixes issues on the packaging guidelines
+ 
  * Fri Apr 19 2024 Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> - 14.7.0-1
  - Update to 14.7.0


```
Koji Scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=117118150


> Just to clarify, you tried to trigger the build correctly. There problem why it wasn't triggered was likely this:
> https://github.com/FrostyX/fedora-review-service/issues/42

Oh... We should manually run fedora-review while the service is unavailable.

> Both approaches are valid, so feel free to continue using this one. I just wanted to let you know in case you were writing a new package in a future.

Thank you for the advice, I will follow the new package guidelines when making
new packages.:)

> This works for rawhide which is important. But just mentioning that it fails for F39 because of
>
>    No matching package to install: 'python3-pyngus'

Sorry, I have not created the f39 branch of python3-pyngus yet, I will prepare
for it.

Thanks in advance,
Hirotaka


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2009155

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202009155%23c16
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux