https://bugzilla.redhat.com/show_bug.cgi?id=2009155 --- Comment #15 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Hello Hirotaka, > [fedora-review-service-build] Just to clarify, you tried to trigger the build correctly. There problem why it wasn't triggered was likely this: https://github.com/FrostyX/fedora-review-service/issues/42 > Name: python-oslo-messaging Nitpick: You can use python-%{pkg_name} > License: ASL 2.0 Since recently, Fedora migrated to using SPDX expressions for license names, so the "ASL 2.0" isn't valid anymore, see $ license-validate "ASL 2.0" $ echo $? The correct license name should be: $ license-fedora2spdx "ASL 2.0" Apache-2.0 > %{py3_install} Just for the record, the specfile follows the 201x-era guidelines https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/ but there is now more current approach using dynamic BuildRequires and so on https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ Both approaches are valid, so feel free to continue using this one. I just wanted to let you know in case you were writing a new package in a future. > BuildRequires: python3-pyngus This works for rawhide which is important. But just mentioning that it fails for F39 because of No matching package to install: 'python3-pyngus' The fedora-review tool complains about the provided MD5sum: - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /tmp/fedora- rawhide-x86_64/review-python-oslo-messaging/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ The mentioned diff is here: diff -U2 -r /tmp/fedora-rawhide-x86_64/review-python-oslo-messaging/upstream-unpacked/Source102/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt /tmp/fedora-rawhide-x86_64/review-python-oslo-messaging/srpm-unpacked/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt-extract/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt --- /tmp/fedora-rawhide-x86_64/review-python-oslo-messaging/upstream-unpacked/Source102/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt 2024-04-30 13:34:18.038159010 +0200 +++ /tmp/fedora-rawhide-x86_64/review-python-oslo-messaging/srpm-unpacked/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt-extract/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt 2024-04-30 13:34:18.157158924 +0200 @@ -44,2 +44,3 @@ =7Dhm -----END PGP PUBLIC KEY BLOCK----- + Overall the package looks good to me, basically only the license name and the checksum error needs to be fixed. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2009155 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202009155%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
