https://bugzilla.redhat.com/show_bug.cgi?id=2277423 --- Comment #2 from Renich Bon Ciric <renich@xxxxxxxxxxxxxxxx> --- (In reply to Mikel Olasagasti Uranga from comment #1) > - This one can be removed: docker/README.md > > > %global godocs docs CHANGELOG.md README.md docker/README.md Done. > - Although correct, I think this time these can be conveted to > "BuildRequires: /usr/bin/easyjson" type of BR. > > > BuildRequires: golang-github-mailru-easyjson > > BuildRequires: golang-google-grpc > > BuildRequires: golang-google-protobuf Done. > - If you plan to use `make` you need a BR on it. Done. > - Doesn't setting GO* env vars before make work? > > > make GOPROXY=off GO111MODULE=off GOPATH=%{gobuilddir}:%{gopath} common No; still getting build errors: Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.mz5mbd + umask 022 + cd /builddir/build/BUILD + cd nextcloud-spreed-signaling-1.2.4 + GOPROXY=off + GO111MODULE=off + GOPATH=/builddir/build/BUILD/nextcloud-spreed-signaling-1.2.4/_build:/usr/share/gocode + make common protoc \ --go_out=. --go_opt=paths=source_relative \ grpc_backend.proto protoc \ --go_out=. --go_opt=paths=source_relative \ grpc_internal.proto protoc \ --go_out=. --go_opt=paths=source_relative \ grpc_mcu.proto protoc \ --go_out=. --go_opt=paths=source_relative \ grpc_sessions.proto protoc \ --go-grpc_out=. --go-grpc_opt=paths=source_relative \ grpc_backend.proto protoc \ --go-grpc_out=. --go-grpc_opt=paths=source_relative \ grpc_internal.proto protoc \ --go-grpc_out=. --go-grpc_opt=paths=source_relative \ grpc_mcu.proto protoc \ --go-grpc_out=. --go-grpc_opt=paths=source_relative \ grpc_sessions.proto rm -f easyjson-bootstrap*.go easyjson -all api_async.go Error parsing api_async.go: file '/builddir/build/BUILD/nextcloud-spreed-signaling-1.2.4/api_async.go' is not in GOPATH '/builddir/build/BUILD/nextcloud-spreed-signaling-1.2.4/_build:/usr/share/gocode' make: *** [Makefile:102: api_async_easyjson.go] Error 1 The full log is at: https://paste.centos.org/view/08c1fffe > - Is client required? Makefile's build section only builds server and proxy. > > > %gobuild -o %{gobuilddir}/bin/client %{goipath}/client > > Documentation refers to it as "A simple client exists to benchmark the > server." It is needed for the tests. I don't think it is needed in the actual package. I don't think proxy is required at all either. > > - Change from this: > > > %{_bindir}/* > > to: > > %{_bindir}/signaling > %{_bindir}/proxy > %{_bindir}/client Done. > - You can remove these to create a binary only package: > > > %gopkginstall > > (...) > > %gopkgfiles Done. > - IIUC this package is meant to be used as a daemon by default? If so > systemd definition and user creation is missing. > > https://github.com/strukturag/nextcloud-spreed-signaling/blob/master/README. > md#running-as-daemon You are right. I haven't included the systemd service unit. I will do this as soon as I can make the package build. > - Does it make sense to split the package into signaling and proxy > subpackages? Or add the proxy subpackage? I think it is worth splitting. You don't always need a proxy. I will do this as soon as I can make the package build. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2277423 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277423%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
