https://bugzilla.redhat.com/show_bug.cgi?id=2277423 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |mikel@xxxxxxxxxxxxxxx --- Comment #1 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- - This one can be removed: docker/README.md > %global godocs docs CHANGELOG.md README.md docker/README.md - Although correct, I think this time these can be conveted to "BuildRequires: /usr/bin/easyjson" type of BR. > BuildRequires: golang-github-mailru-easyjson > BuildRequires: golang-google-grpc > BuildRequires: golang-google-protobuf - If you plan to use `make` you need a BR on it. - Doesn't setting GO* env vars before make work? > make GOPROXY=off GO111MODULE=off GOPATH=%{gobuilddir}:%{gopath} common - Is client required? Makefile's build section only builds server and proxy. > %gobuild -o %{gobuilddir}/bin/client %{goipath}/client Documentation refers to it as "A simple client exists to benchmark the server." - Change from this: > %{_bindir}/* to: %{_bindir}/signaling %{_bindir}/proxy %{_bindir}/client - You can remove these to create a binary only package: > %gopkginstall > (...) > %gopkgfiles - IIUC this package is meant to be used as a daemon by default? If so systemd definition and user creation is missing. https://github.com/strukturag/nextcloud-spreed-signaling/blob/master/README.md#running-as-daemon - Does it make sense to split the package into signaling and proxy subpackages? Or add the proxy subpackage? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2277423 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202277423%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
