https://bugzilla.redhat.com/show_bug.cgi?id=2255842 --- Comment #4 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> --- Here is the first pass as what I spotted. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-Clause License", "*No copyright* MIT License", "BSD 2-Clause License [generated file]", "*No copyright* GNU Lesser General Public License v2.1 or later", "GNU General Public License, Version 3", "BSD 3-Clause License". 60 files have unknown license. Detailed output of licensecheck in /home/jon/rpmbuild/reviews/psmoveapi/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. BSD-2-Clause is the only listed and installed license. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/pkgconfig, /usr/lib/udev, /usr/lib/udev/rules.d [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/udev, /usr/lib/udev/rules.d pkgconf-pkg-config systemd-udev [!]: Final provides and requires are sane (see attachments). - Package must not depend on deprecated() packages. Note: libusb-compat-0.1 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ This one might be required if upstream doesn't support a newer libusb. I'm not sure what the policy is here. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2255842 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202255842%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
