https://bugzilla.redhat.com/show_bug.cgi?id=2274028 Sandro Bonazzola <sbonazzo@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(dbassey@xxxxxxxxx | |m) --- Comment #1 from Sandro Bonazzola <sbonazzo@xxxxxxxxxx> --- I would like someone from RUST team to review as well, but here's my review: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains duplicates in %files! Note: warning: File listed twice: /usr/share/cargo/registry/vhost-device- sound-0.1.0/CHANGELOG.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files - Man page is shipped in devel package instead of in the main package. - See [!] comments below. - I think there's some packaging issue with devel packages for the backends. I see for example: ``` $ rpm -qlp rust-vhost-device-sound+pw-devel-0.1.0-1.fc41.x86_64.rpm /usr/share/cargo/registry/vhost-device-sound-0.1.0/Cargo.toml $ rpm -qlp rust-vhost-device-sound+alsa-backend-devel-0.1.0-1.fc41.x86_64.rpm /usr/share/cargo/registry/vhost-device-sound-0.1.0/Cargo.toml $ rpm -qlp rust-vhost-device-sound-devel-0.1.0-1.fc41.x86_64.rpm /usr/bin/vhost-device-sound /usr/lib/.build-id /usr/lib/.build-id/90/3d5dba274233482f13c18992668a913053a95d /usr/share/cargo/registry/vhost-device-sound-0.1.0 /usr/share/cargo/registry/vhost-device-sound-0.1.0/.cargo-checksum.json /usr/share/cargo/registry/vhost-device-sound-0.1.0/CHANGELOG.md /usr/share/cargo/registry/vhost-device-sound-0.1.0/Cargo.toml /usr/share/cargo/registry/vhost-device-sound-0.1.0/LICENSE-APACHE /usr/share/cargo/registry/vhost-device-sound-0.1.0/LICENSE-BSD-3-Clause /usr/share/cargo/registry/vhost-device-sound-0.1.0/LICENSE.dependencies /usr/share/cargo/registry/vhost-device-sound-0.1.0/README.md /usr/share/cargo/registry/vhost-device-sound-0.1.0/rustfmt.toml /usr/share/cargo/registry/vhost-device-sound-0.1.0/src /usr/share/cargo/registry/vhost-device-sound-0.1.0/src/audio_backends /usr/share/cargo/registry/vhost-device-sound-0.1.0/src/audio_backends.rs /usr/share/cargo/registry/vhost-device-sound-0.1.0/src/audio_backends/alsa /usr/share/cargo/registry/vhost-device-sound-0.1.0/src/audio_backends/alsa.rs /usr/share/cargo/registry/vhost-device-sound-0.1.0/src/audio_backends/alsa/test_utils.rs /usr/share/cargo/registry/vhost-device-sound-0.1.0/src/audio_backends/null.rs /usr/share/cargo/registry/vhost-device-sound-0.1.0/src/audio_backends/pipewire /usr/share/cargo/registry/vhost-device-sound-0.1.0/src/audio_backends/pipewire.rs /usr/share/cargo/registry/vhost-device-sound-0.1.0/src/audio_backends/pipewire/test_utils.rs /usr/share/cargo/registry/vhost-device-sound-0.1.0/src/device.rs /usr/share/cargo/registry/vhost-device-sound-0.1.0/src/lib.rs /usr/share/cargo/registry/vhost-device-sound-0.1.0/src/main.rs /usr/share/cargo/registry/vhost-device-sound-0.1.0/src/stream.rs /usr/share/cargo/registry/vhost-device-sound-0.1.0/src/virtio_sound.rs /usr/share/cargo/registry/vhost-device-sound-0.1.0/vhost-device-sound.1 /usr/share/man/man1/vhost-device-sound.1.gz ``` I would have expected different content there. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "BSD 3-Clause License", "*No copyright* Apache License (v2.0) or bsd_-3-Clause_clause". 8 files have unknown license. Detailed output of licensecheck in licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package requires other packages for directories it uses. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. Note: package is requiring an ExcludeArch and provides justification for it [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1221 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in vhost- device-sound , rust-vhost-device-sound-devel , rust-vhost-device- sound+default-devel , rust-vhost-device-sound+alsa-backend-devel , rust-vhost-device-sound+pw-devel , rust-vhost-device-sound+pw-backend- devel , rust-vhost-device-sound+xen-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. Note: in %install you're installing a man page, just add -p to the install command to preserve the timestamp. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: vhost-device-sound-0.1.0-1.fc41.x86_64.rpm rust-vhost-device-sound-devel-0.1.0-1.fc41.x86_64.rpm rust-vhost-device-sound+default-devel-0.1.0-1.fc41.x86_64.rpm rust-vhost-device-sound+alsa-backend-devel-0.1.0-1.fc41.x86_64.rpm rust-vhost-device-sound+pw-devel-0.1.0-1.fc41.x86_64.rpm rust-vhost-device-sound+pw-backend-devel-0.1.0-1.fc41.x86_64.rpm rust-vhost-device-sound+xen-devel-0.1.0-1.fc41.x86_64.rpm rust-vhost-device-sound-debugsource-0.1.0-1.fc41.x86_64.rpm rust-vhost-device-sound-0.1.0-1.fc41.src.rpm =========================================================================== rpmlint session starts ========================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmplj91uhk_')] checks: 32, packages: 9 rust-vhost-device-sound+alsa-backend-devel.x86_64: E: spelling-error ('Virtio', 'Summary(en_US) Virtio -> Virtuoso') rust-vhost-device-sound+alsa-backend-devel.x86_64: E: spelling-error ('virtio', '%description -l en_US virtio -> virtuoso') rust-vhost-device-sound+default-devel.x86_64: E: spelling-error ('Virtio', 'Summary(en_US) Virtio -> Virtuoso') rust-vhost-device-sound+default-devel.x86_64: E: spelling-error ('virtio', '%description -l en_US virtio -> virtuoso') rust-vhost-device-sound+pw-backend-devel.x86_64: E: spelling-error ('Virtio', 'Summary(en_US) Virtio -> Virtuoso') rust-vhost-device-sound+pw-backend-devel.x86_64: E: spelling-error ('virtio', '%description -l en_US virtio -> virtuoso') rust-vhost-device-sound+pw-devel.x86_64: E: spelling-error ('Virtio', 'Summary(en_US) Virtio -> Virtuoso') rust-vhost-device-sound+pw-devel.x86_64: E: spelling-error ('virtio', '%description -l en_US virtio -> virtuoso') rust-vhost-device-sound+xen-devel.x86_64: E: spelling-error ('Virtio', 'Summary(en_US) Virtio -> Virtuoso') rust-vhost-device-sound+xen-devel.x86_64: E: spelling-error ('virtio', '%description -l en_US virtio -> virtuoso') rust-vhost-device-sound.src: E: spelling-error ('Virtio', 'Summary(en_US) Virtio -> Virtuoso') rust-vhost-device-sound.src: E: spelling-error ('virtio', '%description -l en_US virtio -> virtuoso') rust-vhost-device-sound-devel.x86_64: E: spelling-error ('Virtio', 'Summary(en_US) Virtio -> Virtuoso') rust-vhost-device-sound-devel.x86_64: E: spelling-error ('virtio', '%description -l en_US virtio -> virtuoso') vhost-device-sound.x86_64: E: spelling-error ('Virtio', 'Summary(en_US) Virtio -> Virtuoso') vhost-device-sound.x86_64: E: spelling-error ('virtio', '%description -l en_US virtio -> virtuoso') rust-vhost-device-sound.spec:124: W: setup-not-quiet vhost-device-sound.x86_64: W: no-manual-page-for-binary vhost-device-sound rust-vhost-device-sound+alsa-backend-devel.x86_64: W: no-documentation rust-vhost-device-sound+default-devel.x86_64: W: no-documentation rust-vhost-device-sound+pw-backend-devel.x86_64: W: no-documentation rust-vhost-device-sound+pw-devel.x86_64: W: no-documentation rust-vhost-device-sound+xen-devel.x86_64: W: no-documentation rust-vhost-device-sound.spec: W: %ifarch-applied-patch Patch2: build-fix-for-i386.patch ==================================== 9 packages and 0 specfiles checked; 16 errors, 8 warnings, 44 filtered, 16 badness; has taken 0.8 s ==================================== Rpmlint (debuginfo) ------------------- Checking: rust-vhost-device-sound-devel-debuginfo-0.1.0-1.fc41.x86_64.rpm =========================================================================== rpmlint session starts ========================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2j90pp_6')] checks: 32, packages: 1 ====================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.2 s ===================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 9 rust-vhost-device-sound+pw-devel.x86_64: E: spelling-error ('Virtio', 'Summary(en_US) Virtio -> Virtuoso') rust-vhost-device-sound+pw-devel.x86_64: E: spelling-error ('virtio', '%description -l en_US virtio -> virtuoso') rust-vhost-device-sound+xen-devel.x86_64: E: spelling-error ('Virtio', 'Summary(en_US) Virtio -> Virtuoso') rust-vhost-device-sound+xen-devel.x86_64: E: spelling-error ('virtio', '%description -l en_US virtio -> virtuoso') vhost-device-sound.x86_64: E: spelling-error ('Virtio', 'Summary(en_US) Virtio -> Virtuoso') vhost-device-sound.x86_64: E: spelling-error ('virtio', '%description -l en_US virtio -> virtuoso') rust-vhost-device-sound+default-devel.x86_64: E: spelling-error ('Virtio', 'Summary(en_US) Virtio -> Virtuoso') rust-vhost-device-sound+default-devel.x86_64: E: spelling-error ('virtio', '%description -l en_US virtio -> virtuoso') rust-vhost-device-sound+alsa-backend-devel.x86_64: E: spelling-error ('Virtio', 'Summary(en_US) Virtio -> Virtuoso') rust-vhost-device-sound+alsa-backend-devel.x86_64: E: spelling-error ('virtio', '%description -l en_US virtio -> virtuoso') rust-vhost-device-sound+pw-backend-devel.x86_64: E: spelling-error ('Virtio', 'Summary(en_US) Virtio -> Virtuoso') rust-vhost-device-sound+pw-backend-devel.x86_64: E: spelling-error ('virtio', '%description -l en_US virtio -> virtuoso') rust-vhost-device-sound-devel.x86_64: E: spelling-error ('Virtio', 'Summary(en_US) Virtio -> Virtuoso') rust-vhost-device-sound-devel.x86_64: E: spelling-error ('virtio', '%description -l en_US virtio -> virtuoso') vhost-device-sound.x86_64: W: no-manual-page-for-binary vhost-device-sound rust-vhost-device-sound+pw-devel.x86_64: W: no-documentation rust-vhost-device-sound+xen-devel.x86_64: W: no-documentation rust-vhost-device-sound+default-devel.x86_64: W: no-documentation rust-vhost-device-sound+alsa-backend-devel.x86_64: W: no-documentation rust-vhost-device-sound+pw-backend-devel.x86_64: W: no-documentation 9 packages and 0 specfiles checked; 14 errors, 6 warnings, 46 filtered, 14 badness; has taken 0.6 s Source checksums ---------------- https://crates.io/api/v1/crates/vhost-device-sound/0.1.0/download#/vhost-device-sound-0.1.0.crate : CHECKSUM(SHA256) this package : 8d89731cfe36eb3b57b6eec55b7ed0f79e34b34274fd4f672035b548417c7f09 CHECKSUM(SHA256) upstream package : 8d89731cfe36eb3b57b6eec55b7ed0f79e34b34274fd4f672035b548417c7f09 Requires -------- vhost-device-sound (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libpipewire-0.3.so.0()(64bit) rtld(GNU_HASH) rust-vhost-device-sound-devel (rpmlib, GLIBC filtered): (crate(clap/default) >= 4.4.0 with crate(clap/default) < 5.0.0~) (crate(clap/derive) >= 4.4.0 with crate(clap/derive) < 5.0.0~) (crate(env_logger/default) >= 0.11.0 with crate(env_logger/default) < 0.12.0~) (crate(log/default) >= 0.4.0 with crate(log/default) < 0.5.0~) (crate(thiserror/default) >= 1.0.0 with crate(thiserror/default) < 2.0.0~) (crate(vhost-user-backend/default) >= 0.13.0 with crate(vhost-user-backend/default) < 0.14.0~) (crate(vhost/default) >= 0.10.0 with crate(vhost/default) < 0.11.0~) (crate(vhost/vhost-user-backend) >= 0.10.0 with crate(vhost/vhost-user-backend) < 0.11.0~) (crate(virtio-bindings/default) >= 0.2.1 with crate(virtio-bindings/default) < 0.3.0~) (crate(virtio-queue/default) >= 0.11.0 with crate(virtio-queue/default) < 0.12.0~) (crate(vm-memory/default) >= 0.14.0 with crate(vm-memory/default) < 0.15.0~) (crate(vmm-sys-util/default) >= 0.12.0 with crate(vmm-sys-util/default) < 0.13.0~) cargo ld-linux-x86-64.so.2()(64bit) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libpipewire-0.3.so.0()(64bit) rtld(GNU_HASH) rust-vhost-device-sound+default-devel (rpmlib, GLIBC filtered): cargo crate(vhost-device-sound) crate(vhost-device-sound/alsa-backend) crate(vhost-device-sound/pw-backend) rust-vhost-device-sound+alsa-backend-devel (rpmlib, GLIBC filtered): (crate(alsa/default) >= 0.8.0 with crate(alsa/default) < 0.9.0~) cargo crate(vhost-device-sound) rust-vhost-device-sound+pw-devel (rpmlib, GLIBC filtered): (crate(pipewire/default) >= 0.8.0 with crate(pipewire/default) < 0.9.0~) cargo crate(vhost-device-sound) rust-vhost-device-sound+pw-backend-devel (rpmlib, GLIBC filtered): cargo crate(vhost-device-sound) crate(vhost-device-sound/pw) rust-vhost-device-sound+xen-devel (rpmlib, GLIBC filtered): (crate(vhost-user-backend/xen) >= 0.13.0 with crate(vhost-user-backend/xen) < 0.14.0~) (crate(vhost/xen) >= 0.10.0 with crate(vhost/xen) < 0.11.0~) (crate(vm-memory/xen) >= 0.14.0 with crate(vm-memory/xen) < 0.15.0~) cargo crate(vhost-device-sound) rust-vhost-device-sound-debugsource (rpmlib, GLIBC filtered): Provides -------- vhost-device-sound: vhost-device-sound vhost-device-sound(x86-64) rust-vhost-device-sound-devel: crate(vhost-device-sound) rust-vhost-device-sound-devel rust-vhost-device-sound-devel(x86-64) rust-vhost-device-sound+default-devel: crate(vhost-device-sound/default) rust-vhost-device-sound+default-devel rust-vhost-device-sound+default-devel(x86-64) rust-vhost-device-sound+alsa-backend-devel: crate(vhost-device-sound/alsa-backend) rust-vhost-device-sound+alsa-backend-devel rust-vhost-device-sound+alsa-backend-devel(x86-64) rust-vhost-device-sound+pw-devel: crate(vhost-device-sound/pw) rust-vhost-device-sound+pw-devel rust-vhost-device-sound+pw-devel(x86-64) rust-vhost-device-sound+pw-backend-devel: crate(vhost-device-sound/pw-backend) rust-vhost-device-sound+pw-backend-devel rust-vhost-device-sound+pw-backend-devel(x86-64) rust-vhost-device-sound+xen-devel: crate(vhost-device-sound/xen) rust-vhost-device-sound+xen-devel rust-vhost-device-sound+xen-devel(x86-64) rust-vhost-device-sound-debugsource: rust-vhost-device-sound-debugsource rust-vhost-device-sound-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2274028 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Java, Python, Perl, fonts, R, Ruby, SugarActivity, PHP, Haskell, Ocaml, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2274028 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202274028%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
