https://bugzilla.redhat.com/show_bug.cgi?id=2252229 --- Comment #17 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to Ankur Sinha (FranciscoD) from comment #16) > Issues: > ======= > > - I don't think %ldconfig_scriptlets is required any more. The guidelines > now say: "It is not necessary to call ldconfig when installing shared > libraries." > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries I dropped it. I can't remember where I picked that up. > - Licenses may need a look I ran scancode on the src/ and tpl/ dirs and updated the Licens field accordingly. > - may need to look at whether it bundles Random123/pss (and other things?) Good catch. Random123 was bundled. I'm now using the system Random123. In pss/ there's only two header files, both with an acceptable license. Apparently pss is an acronym for parallel stable sort. I couldn't find a suitable package in the repos. I think it's okay leaving it in. Not sure if I need to add a provides bundled. > - the -{openmpi,mpich}-devel sub packages should probably also Require: > {openmpich/mpich}-devel I think, since they'll be required for development? Why? I haven't seen that done in any of the MPI packages I've touched so far. > - any reason we're not building the tests for the standard build? (but there > are still some default tests that are run in %check) No reason. Just an oversight. It's enabled now for all builds. > - we could generate man pages for the binaries I included generated man pages now for the binaries of the standard package where it makes (kind of) sense. Unfortunately, most of the binaries do not implement `--help` throwing errors regarding missing or unknown arguments. Some even dump core. I'm not sure it makes sense at all. But I left it in for now so you can see for yourself. Spec URL: https://gui1ty.fedorapeople.org/review/sandia-omega-h.spec SRPM URL: https://gui1ty.fedorapeople.org/review/sandia-omega-h-9.34.13-2.fc41.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2252229 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202252229%23c17 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
