[Bug 2252229] Review Request: sandia-omega-h - Reliable mesh adaptation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2252229



--- Comment #16 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
Looks pretty good. A few things we need to look at.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======

- I don't think %ldconfig_scriptlets is required any more. The guidelines now
say: "It is not necessary to call ldconfig when installing shared libraries."
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries

- Licenses may need a look

- may need to look at whether it bundles Random123/pss (and other things?)

- the -{openmpi,mpich}-devel sub packages should probably also Require:
{openmpich/mpich}-devel I think, since they'll be required for development?

- any reason we're not building the tests for the standard build? (but there
are still some default tests that are run in %check)

- we could generate man pages for the binaries

===== MUST items =====

C/C++:
[-]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[?]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.

I see a few license. We'll have to see which ones apply:

licensecheck -r . | sed '/UNKNOWN/ d'
./omega_h-9.34.13/LICENSE: BSD 2-Clause with views sentence
./omega_h-9.34.13/README.md: *No copyright* BSD 2-Clause License
./omega_h-9.34.13/doc/xsdk-compatibility.md: *No copyright* BSD 2-Clause
License
./omega_h-9.34.13/misc/flamegraph.pl: Common Development and Distribution
License
./omega_h-9.34.13/misc/stackcollapse-perf.pl: Common Development and
Distribution License
./omega_h-9.34.13/src/Omega_h_any.hpp: Boost Software License 1.0
./omega_h-9.34.13/src/Omega_h_rbtree.hpp: NTP License
./omega_h-9.34.13/tpl/pss/parallel_stable_sort.hpp: BSD 3-Clause License
./omega_h-9.34.13/tpl/pss/pss_common.hpp: BSD 3-Clause License
./omega_h-9.34.13/tpl/random123/array.h: BSD 3-Clause License
./omega_h-9.34.13/tpl/random123/philox.h: BSD 3-Clause License
./omega_h-9.34.13/tpl/random123/features/clangfeatures.h: BSD 3-Clause License
./omega_h-9.34.13/tpl/random123/features/compilerfeatures.h: BSD 3-Clause
License
./omega_h-9.34.13/tpl/random123/features/gccfeatures.h: BSD 3-Clause License
./omega_h-9.34.13/tpl/random123/features/iccfeatures.h: BSD 3-Clause License
./omega_h-9.34.13/tpl/random123/features/msvcfeatures.h: BSD 3-Clause License
./omega_h-9.34.13/tpl/random123/features/nvccfeatures.h: BSD 3-Clause License
./omega_h-9.34.13/tpl/random123/features/open64features.h: BSD 3-Clause License
./omega_h-9.34.13/tpl/random123/features/openclfeatures.h: BSD 3-Clause License
./omega_h-9.34.13/tpl/random123/features/pgccfeatures.h: BSD 3-Clause License
./omega_h-9.34.13/tpl/random123/features/sse.h: BSD 3-Clause License
./omega_h-9.34.13/tpl/random123/features/sunprofeatures.h: BSD 3-Clause License
./omega_h-9.34.13/tpl/random123/features/xlcfeatures.h: BSD 3-Clause License


[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib64/openmpi/include,
     /usr/lib64/openmpi/lib, /usr/lib64/mpich/lib, /usr/lib64/cmake,
     /usr/lib64/mpich, /usr/lib64/openmpi/bin, /usr/lib64/mpich/include,
     /usr/lib64/mpich/bin, /usr/lib64/openmpi/lib/cmake,
     /usr/lib64/openmpi, /usr/lib64/mpich/lib/cmake

^
Looks fine, the openmpi/mpich packages provide these.

[?]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/openmpi/lib/cmake
^
This is owned by openmpi-devel but that isn't required by the package so it's
unowned.
I think perhaps the {openmpi,mpich}-devel sub-packages should require the
{openmpi,mpich}-devel packages too, since they'll be required for development?

[x]: %build honors applicable compiler flags or justifies otherwise.
[?]: Package contains no bundled libraries without FPC exception.
^
Bundles Random123 and pss? We need to take a look at whether they are used and
replace them with system variants if possible.

[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 8847 bytes in 3 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in sandia-
     omega-h-devel , sandia-omega-h-mpich , sandia-omega-h-mpich-devel ,
     sandia-omega-h-openmpi , sandia-omega-h-openmpi-devel

^
Seems to be fine.

[?]: Package functions as described.
^
Not tested this out yet

[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: sandia-omega-h-9.34.13-1.fc41.x86_64.rpm
          sandia-omega-h-devel-9.34.13-1.fc41.x86_64.rpm
          sandia-omega-h-mpich-9.34.13-1.fc41.x86_64.rpm
          sandia-omega-h-mpich-devel-9.34.13-1.fc41.x86_64.rpm
          sandia-omega-h-openmpi-9.34.13-1.fc41.x86_64.rpm
          sandia-omega-h-openmpi-devel-9.34.13-1.fc41.x86_64.rpm
          sandia-omega-h-debuginfo-9.34.13-1.fc41.x86_64.rpm
          sandia-omega-h-debugsource-9.34.13-1.fc41.x86_64.rpm
          sandia-omega-h-9.34.13-1.fc41.src.rpm
===========================================================================
rpmlint session starts
==========================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmprv6e1nkt')]
checks: 32, packages: 9

sandia-omega-h.src: E: spelling-error ('adaptativity', '%description -l en_US
adaptativity -> adaptability, captivity')
sandia-omega-h.src: E: spelling-error ('adaptivity', '%description -l en_US
adaptivity -> captivity')
sandia-omega-h.src: E: spelling-error ('discretization', '%description -l en_US
discretization -> discretionary, discretion, discrimination')
sandia-omega-h.x86_64: E: spelling-error ('adaptativity', '%description -l
en_US adaptativity -> adaptability, captivity')
sandia-omega-h.x86_64: E: spelling-error ('adaptivity', '%description -l en_US
adaptivity -> captivity')
sandia-omega-h.x86_64: E: spelling-error ('discretization', '%description -l
en_US discretization -> discretionary, discretion, discrimination')
sandia-omega-h-mpich.x86_64: E: spelling-error ('adaptativity', '%description
-l en_US adaptativity -> adaptability, captivity')
sandia-omega-h-mpich.x86_64: E: spelling-error ('adaptivity', '%description -l
en_US adaptivity -> captivity')
sandia-omega-h-mpich.x86_64: E: spelling-error ('discretization', '%description
-l en_US discretization -> discretionary, discretion, discrimination')
sandia-omega-h-openmpi.x86_64: E: spelling-error ('adaptativity', '%description
-l en_US adaptativity -> adaptability, captivity')
sandia-omega-h-openmpi.x86_64: E: spelling-error ('adaptivity', '%description
-l en_US adaptivity -> captivity')
sandia-omega-h-openmpi.x86_64: E: spelling-error ('discretization',
'%description -l en_US discretization -> discretionary, discretion,
discrimination')
sandia-omega-h.spec: W: patch-not-applied Patch0:
build_flags_and_so_version.patch
sandia-omega-h-mpich-devel.x86_64: W: only-non-binary-in-usr-lib
sandia-omega-h-openmpi-devel.x86_64: W: only-non-binary-in-usr-lib
sandia-omega-h.x86_64: W: no-manual-page-for-binary ascii_vtk2osh
sandia-omega-h.x86_64: W: no-manual-page-for-binary msh2osh
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh2vtk
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh_adapt
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh_box
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh_calc
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh_eval_implied
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh_filesystem
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh_fix
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh_part
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh_reorder
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh_scale
sandia-omega-h.x86_64: W: no-manual-page-for-binary oshdiff
sandia-omega-h.x86_64: W: no-manual-page-for-binary vtkdiff
sandia-omega-h-devel.x86_64: W: no-documentation
sandia-omega-h-mpich-devel.x86_64: W: no-documentation
sandia-omega-h-openmpi-devel.x86_64: W: no-documentation
=================================== 9 packages and 0 specfiles checked; 12
errors, 20 warnings, 120 filtered, 12 badness; has taken 3.3 s
===================================




Rpmlint (debuginfo)
-------------------
Checking: sandia-omega-h-openmpi-debuginfo-9.34.13-1.fc41.x86_64.rpm
          sandia-omega-h-mpich-debuginfo-9.34.13-1.fc41.x86_64.rpm
          sandia-omega-h-debuginfo-9.34.13-1.fc41.x86_64.rpm
===========================================================================
rpmlint session starts
==========================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpmqwf_gnb')]
checks: 32, packages: 3

===================================== 3 packages and 0 specfiles checked; 0
errors, 0 warnings, 106 filtered, 0 badness; has taken 2.1 s
====================================





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 10

sandia-omega-h-openmpi.x86_64: E: spelling-error ('adaptativity', '%description
-l en_US adaptativity -> adaptability, captivity')
sandia-omega-h-openmpi.x86_64: E: spelling-error ('adaptivity', '%description
-l en_US adaptivity -> captivity')
sandia-omega-h-openmpi.x86_64: E: spelling-error ('discretization',
'%description -l en_US discretization -> discretionary, discretion,
discrimination')
sandia-omega-h.x86_64: E: spelling-error ('adaptativity', '%description -l
en_US adaptativity -> adaptability, captivity')
sandia-omega-h.x86_64: E: spelling-error ('adaptivity', '%description -l en_US
adaptivity -> captivity')
sandia-omega-h.x86_64: E: spelling-error ('discretization', '%description -l
en_US discretization -> discretionary, discretion, discrimination')
sandia-omega-h-mpich.x86_64: E: spelling-error ('adaptativity', '%description
-l en_US adaptativity -> adaptability, captivity')
sandia-omega-h-mpich.x86_64: E: spelling-error ('adaptivity', '%description -l
en_US adaptivity -> captivity')
sandia-omega-h-mpich.x86_64: E: spelling-error ('discretization', '%description
-l en_US discretization -> discretionary, discretion, discrimination')
sandia-omega-h-openmpi-devel.x86_64: W: only-non-binary-in-usr-lib
sandia-omega-h-mpich-devel.x86_64: W: only-non-binary-in-usr-lib
sandia-omega-h.x86_64: W: no-manual-page-for-binary ascii_vtk2osh
sandia-omega-h.x86_64: W: no-manual-page-for-binary msh2osh
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh2vtk
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh_adapt
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh_box
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh_calc
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh_eval_implied
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh_filesystem
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh_fix
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh_part
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh_reorder
sandia-omega-h.x86_64: W: no-manual-page-for-binary osh_scale
sandia-omega-h.x86_64: W: no-manual-page-for-binary oshdiff
sandia-omega-h.x86_64: W: no-manual-page-for-binary vtkdiff
sandia-omega-h-openmpi-devel.x86_64: W: no-documentation
sandia-omega-h-mpich-devel.x86_64: W: no-documentation
sandia-omega-h-devel.x86_64: W: no-documentation
 10 packages and 0 specfiles checked; 9 errors, 19 warnings, 228 filtered, 9
badness; has taken 10.3 s 



Source checksums
----------------
https://github.com/sandialabs/omega_h/archive/v9.34.13/omega_h-9.34.13.tar.gz :
  CHECKSUM(SHA256) this package     :
2eadfd6d634abc0b50396a82fd446f8f0b586ba6e64788c47827162c2aadec02
  CHECKSUM(SHA256) upstream package :
2eadfd6d634abc0b50396a82fd446f8f0b586ba6e64788c47827162c2aadec02


Requires
--------
sandia-omega-h (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libm.so.6()(64bit)
    libomega_h.so.9()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.15)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libz.so.1()(64bit)
    libz.so.1(ZLIB_1.2.0)(64bit)
    rtld(GNU_HASH)

sandia-omega-h-devel (rpmlib, GLIBC filtered):
    cmake-filesystem(x86-64)
    sandia-omega-h(x86-64)

sandia-omega-h-mpich (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libm.so.6()(64bit)
    libmpi.so.12()(64bit)(mpich-x86_64)
    libomega_h.so.9()(64bit)(mpich-x86_64)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.15)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libz.so.1()(64bit)
    libz.so.1(ZLIB_1.2.0)(64bit)
    mpich
    rtld(GNU_HASH)

sandia-omega-h-mpich-devel (rpmlib, GLIBC filtered):
    sandia-omega-h-mpich(x86-64)

sandia-omega-h-openmpi (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libm.so.6()(64bit)
    libmpi.so.40()(64bit)(openmpi-x86_64)
    libomega_h.so.9()(64bit)(openmpi-x86_64)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.15)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libz.so.1()(64bit)
    libz.so.1(ZLIB_1.2.0)(64bit)
    openmpi
    rtld(GNU_HASH)

sandia-omega-h-openmpi-devel (rpmlib, GLIBC filtered):
    sandia-omega-h-openmpi(x86-64)

sandia-omega-h-debuginfo (rpmlib, GLIBC filtered):

sandia-omega-h-debugsource (rpmlib, GLIBC filtered):



Provides
--------
sandia-omega-h:
    libomega_h.so.9()(64bit)
    sandia-omega-h
    sandia-omega-h(x86-64)

sandia-omega-h-devel:
    cmake(Omega_h)
    cmake(omega_h)
    sandia-omega-h-devel
    sandia-omega-h-devel(x86-64)

sandia-omega-h-mpich:
    libomega_h.so.9()(64bit)(mpich-x86_64)
    sandia-omega-h-mpich
    sandia-omega-h-mpich(x86-64)

sandia-omega-h-mpich-devel:
    sandia-omega-h-mpich-devel
    sandia-omega-h-mpich-devel(x86-64)

sandia-omega-h-openmpi:
    libomega_h.so.9()(64bit)(openmpi-x86_64)
    sandia-omega-h-openmpi
    sandia-omega-h-openmpi(x86-64)

sandia-omega-h-openmpi-devel:
    sandia-omega-h-openmpi-devel
    sandia-omega-h-openmpi-devel(x86-64)

sandia-omega-h-debuginfo:
    debuginfo(build-id)
    sandia-omega-h-debuginfo
    sandia-omega-h-debuginfo(x86-64)

sandia-omega-h-debugsource:
    sandia-omega-h-debugsource
    sandia-omega-h-debugsource(x86-64)



Diff spec file in url and in SRPM
---------------------------------
---
/home/asinha/dump/fedora-reviews/2252229-sandia-omega-h/srpm/sandia-omega-h.spec
   2024-03-09 14:51:30.715420879 +0000
+++
/home/asinha/dump/fedora-reviews/2252229-sandia-omega-h/srpm-unpacked/sandia-omega-h.spec
  2024-03-08 00:00:00.000000000 +0000
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.6.1)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 1;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
 %global forgeurl https://github.com/sandialabs/omega_h

@@ -440,3 +450,39 @@

 %changelog
-%autochangelog
+## START: Generated by rpmautospec
+* Fri Mar 08 2024 Sandro <devel@xxxxxxxxxxxxx> - 9.34.13-1
+- Package version 9.34.13
+
+* Tue Dec 12 2023 Sandro <devel@xxxxxxxxxxxxx> - 10.1.0-11
+- Fix summary of various sub packages
+
+* Tue Dec 12 2023 Sandro <devel@xxxxxxxxxxxxx> - 10.1.0-10
+- Disable examples
+
+* Tue Dec 12 2023 Sandro <devel@xxxxxxxxxxxxx> - 10.1.0-9
+- Add conditional for Omega_h_THROW bool
+
+* Thu Nov 30 2023 Sandro <devel@xxxxxxxxxxxxx> - 10.1.0-8
+- Add examples as additional doc package
+
+* Wed Nov 29 2023 Sandro <devel@xxxxxxxxxxxxx> - 10.1.0-7
+- Add build option for OpenMP
+
+* Wed Nov 29 2023 Sandro <devel@xxxxxxxxxxxxx> - 10.1.0-6
+- Enable and run tests
+
+* Wed Nov 29 2023 Sandro <devel@xxxxxxxxxxxxx> - 10.1.0-5
+- Fix MPI libs installed into wrong directory
+
+* Wed Nov 29 2023 Sandro <devel@xxxxxxxxxxxxx> - 10.1.0-4
+- Add corresponding suffix to MPI binaries
+
+* Tue Nov 28 2023 Sandro <devel@xxxxxxxxxxxxx> - 10.1.0-3
+- Add OpenMPI build
+
+* Tue Nov 28 2023 Sandro <devel@xxxxxxxxxxxxx> - 10.1.0-2
+- Add MPICH build
+
+* Mon Nov 27 2023 Sandro <devel@xxxxxxxxxxxxx> - 10.1.0-1
+- Initial package
+## END: Generated by rpmautospec


Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2252229
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Generic, Shell-api
Disabled plugins: PHP, Python, Haskell, Java, SugarActivity, R, fonts, Perl,
Ocaml
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2252229

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202252229%23c16
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux