https://bugzilla.redhat.com/show_bug.cgi?id=2267876 loise@xxxxxxx <loise@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(loise@xxxxxxx) | --- Comment #5 from loise@xxxxxxx <loise@xxxxxxx> --- (In reply to Jan Grulich from comment #4) > 1) Looks like BR: qt6-qtbase-static and qt6-qtdeclarative-static are not > needed? At least I can build it without it and don't see any complain Well, then drop them :) > 2) The commented workaround can be dropped if the issue was fixed in GCC? Yes > 3) Was there an alternative of the cooker binary in Qt5? If not, we might > not need to add the -qt6 suffix? That's already a presumption that we will end up with a -qt7 version in the future. The package is new, so you're right, it's not needed really. Drop it if you want :) > 4) I think the thing checking "QMAKE_PRL_BUILD_DIR" is not needed? I guess > it's not needed in any of Qt6 package we have and should be perhaps removed? > I'm guessing because it's qmake related and we don't use qmake anymore. I > also don't see any *.la library being installed. yes, we're using cmake, not qmake. I simply copied that from another qt6 package :) so drop it if we drop it everywhere ? > 5) Shouldn't this package own %{_qt6_libdir}/cmake/Qt6Quick3DPhysics and > similar directories? ah yes, I'm sorry I forgot that. It's owned only by this package, yes. Do you want me to fix this or are you doing it while at it and just import so we get this out the door ? admin will be kde-sig anyway, so there's not necessity for me to own the package at all. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2267876 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202267876%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
